diff options
| author | Benaka Moorthi <benaka.moorthi@gmail.com> | 2013-09-14 23:38:29 +0400 |
|---|---|---|
| committer | Benaka Moorthi <benaka.moorthi@gmail.com> | 2013-09-14 23:38:29 +0400 |
| commit | e36142a6a9a2e0f0b44019b546641fbd4c84ceb5 (patch) | |
| tree | 4335e5001c81a5db65245614712bf2b8f3b7d053 | |
| parent | 62f5478f8310c2e9a14612ac0fc2d901269c74d5 (diff) | |
Refs #4041, default to HtmlTable if visualization ID is invalid and filled out a function doc.
| -rw-r--r-- | core/DataTableVisualization.php | 6 | ||||
| -rw-r--r-- | core/ViewDataTable.php | 3 |
2 files changed, 5 insertions, 4 deletions
diff --git a/core/DataTableVisualization.php b/core/DataTableVisualization.php index 04760b0462..83a6021891 100644 --- a/core/DataTableVisualization.php +++ b/core/DataTableVisualization.php @@ -219,14 +219,14 @@ abstract class DataTableVisualization * Returns the visualization class by it's viewDataTable ID. * * @param string $id The visualization ID. - * @return string The visualization class name. - * @throws \Exception if $id is not a valid visualization ID. + * @return string The visualization class name. If $id is not a valid ID, the HtmlTable visualization + * is returned. */ public static function getClassFromId($id) { $visualizationClasses = self::getAvailableVisualizations(); if (!isset($visualizationClasses[$id])) { - throw new \Exception("Invalid DataTable visualization ID: '$id'."); + return $visualizationClasses['table']; } return $visualizationClasses[$id]; } diff --git a/core/ViewDataTable.php b/core/ViewDataTable.php index 8f2b0a88c8..09634c04b1 100644 --- a/core/ViewDataTable.php +++ b/core/ViewDataTable.php @@ -408,7 +408,8 @@ class ViewDataTable } /** - * TODO + * Sets visualization properties using data in a visualization's default property values + * array. */ private function setVisualizationPropertiesFromMetadata($properties) { |