Fix TrackerTest.php (includes fix to RequestCommand due to cache use in UrlHelper::getArrayFromQueryString).

1 files changed, 3 insertions, 0 deletions

diff --git a/core/UrlHelper.php b/core/UrlHelper.php
index 20501515f2..bcea3c979f 100644
--- a/core/UrlHelper.php
+++ b/core/UrlHelper.php
@@ -156,6 +156,9 @@ class UrlHelper
             return array();
         }
 
+        // TODO: this method should not use a cache. callers should instead have their own cache, configured through DI.
+        //       one undesirable side effect of using a cache here, is that this method can now init the StaticContainer, which makes setting
+        //       test environment for RequestCommand more complicated.
         $cache    = Cache::getTransientCache();
         $cacheKey = 'arrayFromQuery' . $urlQuery;