Avoid filesystem checks when process was set as finished (#16954)

Because in CliMulti we might check in a loop for every process constantly if they are finished. It won't help all that much but better to not check every time the file system when it is not needed.

There be many other things we could improve there. Will add some comments but probably best not to do them (or we'll see if it's needed later)

1 files changed, 6 insertions, 0 deletions

diff --git a/core/CliMulti/Process.php b/core/CliMulti/Process.php
index daed5a85c4..bb0583c4ad 100644
--- a/core/CliMulti/Process.php
+++ b/core/CliMulti/Process.php
@@ -21,6 +21,7 @@ use Piwik\SettingsServer;
  */
 class Process
 {
+    private $finished = null;
     private $pidFile = '';
     private $timeCreation = null;
     private $isSupported = null;
@@ -81,6 +82,10 @@ class Process
 
     public function hasFinished()
     {
+        if ($this->finished) {
+            return true;
+        }
+
         $content = $this->getPidFileContent();
 
         return !$this->doesPidFileExist($content);
@@ -129,6 +134,7 @@ class Process
 
     public function finishProcess()
     {
+        $this->finished = true;
         Filesystem::deleteFileIfExists($this->pidFile);
     }