diff options
author | Benaka <diosmosis@users.noreply.github.com> | 2017-12-03 13:32:15 +0300 |
---|---|---|
committer | Matthieu Aubry <mattab@users.noreply.github.com> | 2017-12-03 13:32:15 +0300 |
commit | 7d35aea046986747911ac3063bb738647a2d3a97 (patch) | |
tree | 3cf41d88f818dbf2d8029df435fd59d2b8ab5513 /misc | |
parent | e7ef6302d69d6fa42212e0910b90dee07c0d35d3 (diff) |
Several fixes/improvements to angular period selector (#12319)
* If a period is filtered out, the result of the periods array becomes an object which breaks the period selector which expects an array.
* Use $onInit instead of directive constructor. Seems angular.js silences errors when this is done.
* Parse previousN/lastN dates correctly in angular periods service.
* Parse periods using piwikPeriods client side, since we cannot assume a date range. Also if an invalid is used for period/date, display ERROR in the period selector.
* Angular will swallow errors from datepicker.parseDate, so add a console.log for developer sanity + make sure period selector has consistent state even when period/date values are invalid (& result in failed date parsing).
* Update misc/log-analytics submodule to latest.
Diffstat (limited to 'misc')
m--------- | misc/log-analytics | 0 |
1 files changed, 0 insertions, 0 deletions
diff --git a/misc/log-analytics b/misc/log-analytics -Subproject cdb7c3981e0af52ce9666a5721c52a28f16cf96 +Subproject 05a5154712fd9324f31422cace1555693ef3934 |