Rewrite cron archiving process for easier maintenance and performance (#15499)

* Adding initial new code for cron archive rewrite.

* first pass at removing unused CronArchive code.

* unfinished commit

* fill out archiveinvalidator code

* getting some tests to pass

* unfinished commit

* fixing part of test

* Another test fix.

* another sql change

* fix broken merge or something else that went wrong

* Couple more fixes and extra logs.

* Fixing enough issues to get core archive command to run completely.

* Fix and log change.

* Fixed more segment/test related issues for CronArchiveTest. Includes optimization for no visits for period + segment process from handling.

* another optimization and possible build fix

* no visit optimization

* test fix

* Implement archiving_custom_ranges logic w/ queue based implementation

* fixes to get archivecrontest to work

* add logic to invalidate today period

* fix optimization and some tests

* Fixing more tests.

* Fixing more tests

* debug travis failure

* more test fixes

* more test fixes, removing more unneeded code, handling some TODOs

* Handle more TODOs including creating ArchiveFilter class for some cli options.

* tests and todos

* idarchives are specific to table + start on archivefilter tests

* one test

* more TODOs and tests

* more tests and todo taken care of

* handle more todos

* fixing more tests

* fix comment

* make sure autoarchiving is enabled for segments when cron archive picks them up

* Fixing test.

* apply more pr feedback

* order by date1 asc

* quick refactor

* use batch insert instead of createDummyArchives

* apply rest of pr feedback

* add removed events, add new test, fix an issue (when deleting idarchives older than do not lump all segments together).

* re-add fixed/shared siteids

* fix tests

* incomplete commit

* Insert archive entries into archive_invalidations table.

* Use invalidations table in core:archive and get ArchiveCronTest to pass.

* fixing some tests

* debugging travis

* fix more tests & remove DONE_IN_PROGRESS which is no longer used.

* fix more tests

* apply review feedback

* fix tests

* try fixing alltests build

* try again

* try again

* Move archive_invalidations update to new beta since omnifixture was updated w/o it.

* Another fix.

1 files changed, 11 insertions, 11 deletions

diff --git a/plugins/Annotations/tests/System/AnnotationsTest.php b/plugins/Annotations/tests/System/AnnotationsTest.php
index 027d97eac5..65b9dbcaf2 100644
--- a/plugins/Annotations/tests/System/AnnotationsTest.php
+++ b/plugins/Annotations/tests/System/AnnotationsTest.php
@@ -103,7 +103,7 @@ class AnnotationsTest extends SystemTestCase
             API::getInstance()->add("1,2,3", "2012-01-01", "whatever");
             $this->fail("add should fail when given multiple sites in idSite");
         } catch (Exception $ex) {
-            // pass
+            $this->assertTrue(true); // pass
         }
     }
 
@@ -113,7 +113,7 @@ class AnnotationsTest extends SystemTestCase
             API::getInstance()->add(self::$fixture->idSite1, "invaliddate", "whatever");
             $this->fail("add should fail when given invalid date");
         } catch (Exception $ex) {
-            // pass
+            $this->assertTrue(true); // pass
         }
     }
 
@@ -123,7 +123,7 @@ class AnnotationsTest extends SystemTestCase
             API::getInstance()->save("1,2,3", 0);
             $this->fail("save should fail when given multiple sites");
         } catch (Exception $ex) {
-            // pass
+            $this->assertTrue(true); // pass
         }
     }
 
@@ -133,7 +133,7 @@ class AnnotationsTest extends SystemTestCase
             API::getInstance()->save(self::$fixture->idSite1, 0, "invaliddate");
             $this->fail("save should fail when given an invalid date");
         } catch (Exception $ex) {
-            // pass
+            $this->assertTrue(true); // pass
         }
     }
 
@@ -143,7 +143,7 @@ class AnnotationsTest extends SystemTestCase
             API::getInstance()->save(self::$fixture->idSite1, -1);
             $this->fail("save should fail when given an invalid note id");
         } catch (Exception $ex) {
-            // pass
+            $this->assertTrue(true); // pass
         }
     }
 
@@ -153,7 +153,7 @@ class AnnotationsTest extends SystemTestCase
             API::getInstance()->delete("1,2,3", 0);
             $this->fail("delete should fail when given multiple site IDs");
         } catch (Exception $ex) {
-            // pass
+            $this->assertTrue(true); // pass
         }
     }
 
@@ -163,7 +163,7 @@ class AnnotationsTest extends SystemTestCase
             API::getInstance()->delete(self::$fixture->idSite1, -1);
             $this->fail("delete should fail when given an invalid site ID");
         } catch (Exception $ex) {
-            // pass
+            $this->assertTrue(true); // pass
         }
     }
 
@@ -173,7 +173,7 @@ class AnnotationsTest extends SystemTestCase
             API::getInstance()->get("1,2,3", 0);
             $this->fail("get should fail when given multiple site IDs");
         } catch (Exception $ex) {
-            // pass
+            $this->assertTrue(true); // pass
         }
     }
 
@@ -183,7 +183,7 @@ class AnnotationsTest extends SystemTestCase
             API::getInstance()->get(self::$fixture->idSite1, -1);
             $this->fail("get should fail when given an invalid note ID");
         } catch (Exception $ex) {
-            // pass
+            $this->assertTrue(true); // pass
         }
     }
 
@@ -226,7 +226,7 @@ class AnnotationsTest extends SystemTestCase
             API::getInstance()->get(self::$fixture->idSite1, 1);
             $this->fail("failed to delete annotation");
         } catch (Exception $ex) {
-            // pass
+            $this->assertTrue(true); // pass
         }
     }
 
@@ -275,7 +275,7 @@ class AnnotationsTest extends SystemTestCase
                 $request->process();
                 $this->fail($failMessage);
             } catch (Exception $ex) {
-                // pass
+                $this->assertTrue(true); // pass
             }
         } else {
             $request = new Request($request);