diff options
author | Kate Butler <kate@innocraft.com> | 2019-06-18 07:45:33 +0300 |
---|---|---|
committer | Matthieu Aubry <mattab@users.noreply.github.com> | 2019-06-18 07:45:33 +0300 |
commit | 57f7184a0dc49df4eacbbd27ca0aef909668b410 (patch) | |
tree | 2e859a11c514d1d7e8ccd302d42703c4897cb2c1 /plugins/CoreHome/angularjs/common/directives | |
parent | 3cdce09b6b27fa8378b2b7eec55760f3aa04951d (diff) |
Ask users to leave a review for Matomo (#14432)
* Ask users to leave a review for Matomo - WIP commit
* Unit tests for feedback reminder popup
* Tidying up
* Add content to popup, also display on help page and after thumbs-up rating
* Make UI tests; move logic out of API into Controller; tidying up
* FIX UI tests
* Use SVG icons
* Fix test
* New expected screenshot for test; tear down feedback reminder option so that other tests won't display it
* New fixture for FeedbackPopup tests
* Move feedback form UI spec out of UIIntegration, update screenshot
* Check auth on updateFeedbackReminderDate() route
* PR changes
* Fix bug from typecasting
Diffstat (limited to 'plugins/CoreHome/angularjs/common/directives')
-rw-r--r-- | plugins/CoreHome/angularjs/common/directives/dialog.js | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/plugins/CoreHome/angularjs/common/directives/dialog.js b/plugins/CoreHome/angularjs/common/directives/dialog.js index 5ffa3cb513..41ad784bfc 100644 --- a/plugins/CoreHome/angularjs/common/directives/dialog.js +++ b/plugins/CoreHome/angularjs/common/directives/dialog.js @@ -35,7 +35,13 @@ scope.$eval(attrs.yes); setTimeout(function () { scope.$apply(); }, 0); } - }}, { + }, no: function() { + if (attrs.no) { + scope.$eval(attrs.no); + setTimeout(function () { scope.$apply(); }, 0); + } + } + }, { complete: function () { setTimeout(function () { scope.$apply($parse(attrs.piwikDialog).assign(scope, false)); |