diff options
author | diosmosis <diosmosis@users.noreply.github.com> | 2019-07-16 07:33:25 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-07-16 07:33:25 +0300 |
commit | e4c1f1f92114ca03947e9932935e4b4195ae1604 (patch) | |
tree | 86d3f38165ee87eb4c7f8a36dc8bdb779c04fb22 /plugins/CoreHome | |
parent | 75c4c9d3a8be5b9d035f086c3b2edb45afaed61a (diff) |
Keep top level nb_visits_converted metric (#14253)
* Do not remove nb_visits_converted when archiving goal reports since it should differ from sum of conversions.
* If metric is not available, compute dynamically by using max nb_visits_converted.
* Ignore abandoned cart conversions when calculating visit converted.
* In case goals column is empty.
* remove processed metric code since it is not correct
* do not remove visits converted metric for overview
* fix tests
* Fixing test
* fix test
* update test files
* update submodules
* Update expected screenshots & try to fix some random failures.
* Update expected UI test export results.
* two ui test fixes
* Fix couple UI test failures.
* fix random php test failure
Diffstat (limited to 'plugins/CoreHome')
-rw-r--r-- | plugins/CoreHome/Columns/Metrics/ConversionRate.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plugins/CoreHome/Columns/Metrics/ConversionRate.php b/plugins/CoreHome/Columns/Metrics/ConversionRate.php index 86c2cd26ee..4c07d9febf 100644 --- a/plugins/CoreHome/Columns/Metrics/ConversionRate.php +++ b/plugins/CoreHome/Columns/Metrics/ConversionRate.php @@ -8,6 +8,7 @@ namespace Piwik\Plugins\CoreHome\Columns\Metrics; use Piwik\DataTable\Row; +use Piwik\Metrics; use Piwik\Metrics\Formatter; use Piwik\Piwik; use Piwik\Plugin\ProcessedMetric; @@ -45,7 +46,6 @@ class ConversionRate extends ProcessedMetric { $nbVisitsConverted = $this->getMetric($row, 'nb_visits_converted'); $nbVisits = $this->getMetric($row, 'nb_visits'); - return Piwik::getQuotientSafe($nbVisitsConverted, $nbVisits, $precision = 4); } }
\ No newline at end of file |