Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/matomo-org/matomo.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBenaka Moorthi <benaka.moorthi@gmail.com>2013-08-09 21:59:20 +0400
committerBenaka Moorthi <benaka.moorthi@gmail.com>2013-08-09 21:59:40 +0400
commit2549406e1212ad57b05b3a01ac846e11c25184ee (patch)
tree22fc902011fbde4eb158c3ba101971c8d37f18ad /plugins/CoreVisualizations/JqplotDataGenerator/Evolution.php
parentc18fcdf7e5cdb0afa3fa180520bab1e3af848a33 (diff)
Refs #4041, fix regression when evolution graph tries to display empty graph.
Diffstat (limited to 'plugins/CoreVisualizations/JqplotDataGenerator/Evolution.php')
-rw-r--r--plugins/CoreVisualizations/JqplotDataGenerator/Evolution.php16
1 files changed, 11 insertions, 5 deletions
diff --git a/plugins/CoreVisualizations/JqplotDataGenerator/Evolution.php b/plugins/CoreVisualizations/JqplotDataGenerator/Evolution.php
index c24ddbb279..2d4f3e93e1 100644
--- a/plugins/CoreVisualizations/JqplotDataGenerator/Evolution.php
+++ b/plugins/CoreVisualizations/JqplotDataGenerator/Evolution.php
@@ -13,6 +13,7 @@ namespace Piwik\Plugins\CoreVisualizations\JqplotDataGenerator;
use Piwik\Piwik;
use Piwik\Common;
use Piwik\DataTable;
+use Piwik\DataTable\Row;
use Piwik\ViewDataTable;
use Piwik\Url;
use Piwik\Plugins\CoreVisualizations\JqplotDataGenerator;
@@ -64,7 +65,13 @@ class Evolution extends JqplotDataGenerator
$yAxisLabelToUnit = array();
$yAxisLabelToValue = array();
foreach ($dataTable->getArray() as $idDataTable => $childTable) {
- foreach ($childTable->getRows() as $row) {
+ if ($childTable->getRowsCount() > 0) {
+ $rows = $childTable->getRows();
+ } else {
+ $rows = array(new Row());
+ }
+
+ foreach ($rows as $row) {
$rowLabel = $row->getColumn('label');
// put together configuration for row picker.
@@ -80,10 +87,9 @@ class Evolution extends JqplotDataGenerator
// build data for request columns
foreach ($requestedColumnNames as $requestedColumnName) {
$yAxisLabel = $this->getSeriesLabel($rowLabel, $requestedColumnName);
- if (($columnValue = $row->getColumn($requestedColumnName)) !== false) {
- $yAxisLabelToValue[$yAxisLabel][$idDataTable] = $columnValue;
- $yAxisLabelToUnit[$yAxisLabel] = $units[$requestedColumnName];
- }
+
+ $yAxisLabelToValue[$yAxisLabel][$idDataTable] = $row->getColumn($requestedColumnName) ?: 0;
+ $yAxisLabelToUnit[$yAxisLabel] = $units[$requestedColumnName];
}
}
}