diff options
| author | diosmosis <diosmosis@users.noreply.github.com> | 2019-07-16 07:33:25 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-07-16 07:33:25 +0300 |
| commit | e4c1f1f92114ca03947e9932935e4b4195ae1604 (patch) | |
| tree | 86d3f38165ee87eb4c7f8a36dc8bdb779c04fb22 /plugins/DevicesDetection | |
| parent | 75c4c9d3a8be5b9d035f086c3b2edb45afaed61a (diff) | |
Keep top level nb_visits_converted metric (#14253)
* Do not remove nb_visits_converted when archiving goal reports since it should differ from sum of conversions.
* If metric is not available, compute dynamically by using max nb_visits_converted.
* Ignore abandoned cart conversions when calculating visit converted.
* In case goals column is empty.
* remove processed metric code since it is not correct
* do not remove visits converted metric for overview
* fix tests
* Fixing test
* fix test
* update test files
* update submodules
* Update expected screenshots & try to fix some random failures.
* Update expected UI test export results.
* two ui test fixes
* Fix couple UI test failures.
* fix random php test failure
Diffstat (limited to 'plugins/DevicesDetection')
3 files changed, 14 insertions, 0 deletions
diff --git a/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getBrand_day.xml b/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getBrand_day.xml index d6790fc1ae..703ec64682 100644 --- a/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getBrand_day.xml +++ b/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getBrand_day.xml @@ -9,6 +9,7 @@ <max_actions>1</max_actions> <sum_visit_length>6</sum_visit_length> <bounce_count>4</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>2</nb_conversions> @@ -30,6 +31,7 @@ <max_actions>1</max_actions> <sum_visit_length>1808</sum_visit_length> <bounce_count>3</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>3</nb_conversions> @@ -51,6 +53,7 @@ <max_actions>2</max_actions> <sum_visit_length>721</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>1</nb_conversions> @@ -98,6 +101,7 @@ <max_actions>1</max_actions> <sum_visit_length>1084</sum_visit_length> <bounce_count>1</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>1</nb_conversions> diff --git a/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getModel_day.xml b/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getModel_day.xml index 6442db0437..2d6509f655 100644 --- a/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getModel_day.xml +++ b/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getModel_day.xml @@ -9,6 +9,7 @@ <max_actions>1</max_actions> <sum_visit_length>3</sum_visit_length> <bounce_count>2</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>1</nb_conversions> @@ -29,6 +30,7 @@ <max_actions>1</max_actions> <sum_visit_length>3</sum_visit_length> <bounce_count>2</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>1</nb_conversions> @@ -49,6 +51,7 @@ <max_actions>1</max_actions> <sum_visit_length>724</sum_visit_length> <bounce_count>2</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>2</nb_conversions> @@ -69,6 +72,7 @@ <max_actions>1</max_actions> <sum_visit_length>1084</sum_visit_length> <bounce_count>1</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>1</nb_conversions> @@ -89,6 +93,7 @@ <max_actions>2</max_actions> <sum_visit_length>721</sum_visit_length> <bounce_count>0</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>1</nb_conversions> @@ -133,6 +138,7 @@ <max_actions>1</max_actions> <sum_visit_length>1084</sum_visit_length> <bounce_count>1</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>1</nb_conversions> diff --git a/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getType_day.xml b/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getType_day.xml index 069641e689..6242c1719a 100644 --- a/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getType_day.xml +++ b/plugins/DevicesDetection/tests/System/expected/test___DevicesDetection.getType_day.xml @@ -9,6 +9,7 @@ <max_actions>1</max_actions> <sum_visit_length>1087</sum_visit_length> <bounce_count>4</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>2</nb_conversions> @@ -30,6 +31,7 @@ <max_actions>2</max_actions> <sum_visit_length>724</sum_visit_length> <bounce_count>2</bounce_count> + <nb_visits_converted>2</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>2</nb_conversions> @@ -51,6 +53,7 @@ <max_actions>1</max_actions> <sum_visit_length>724</sum_visit_length> <bounce_count>2</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>2</nb_conversions> @@ -71,6 +74,7 @@ <max_actions>1</max_actions> <sum_visit_length>1084</sum_visit_length> <bounce_count>1</bounce_count> + <nb_visits_converted>1</nb_visits_converted> <goals> <row idgoal='1'> <nb_conversions>1</nb_conversions> |