Make segmented visitor log in sales page only display visits with orders. (#14079)

* Make segmented visitor log in sales page only display visits with orders.

* Remove some uses.

* Leave out invalid characters in widget unique ID.

* Change widget ID as well as report ID.

1 files changed, 5 insertions, 3 deletions

diff --git a/plugins/Goals/Pages.php b/plugins/Goals/Pages.php
index c9410f2807..2373ea82cd 100644
--- a/plugins/Goals/Pages.php
+++ b/plugins/Goals/Pages.php
@@ -8,7 +8,6 @@
  */
 namespace Piwik\Plugins\Goals;
 
-use Piwik\Cache;
 use Piwik\Common;
 use Piwik\Piwik;
 use Piwik\Plugins\CoreVisualizations\Visualizations\JqplotGraph\Evolution;
@@ -156,7 +155,9 @@ class Pages
         $config->setParameters(array('idGoal' => Piwik::LABEL_ID_GOAL_IS_ECOMMERCE_ORDER));
         $config->setOrder(5);
         $config->setIsNotWidgetizable();
-        $this->buildGoalByDimensionView(Piwik::LABEL_ID_GOAL_IS_ECOMMERCE_ORDER, $config);
+
+        $extraParameters = [ 'segmented_visitor_log_segment_suffix' => 'visitEcommerceStatus==ordered' ];
+        $this->buildGoalByDimensionView(Piwik::LABEL_ID_GOAL_IS_ECOMMERCE_ORDER, $config, $extraParameters);
 
         return array($config);
     }
@@ -253,7 +254,7 @@ class Pages
         return $config;
     }
 
-    private function buildGoalByDimensionView($idGoal, WidgetContainerConfig $container)
+    private function buildGoalByDimensionView($idGoal, WidgetContainerConfig $container, $extraParameters = [])
     {
         $container->setLayout('ByDimension');
         $ecommerce = ($idGoal == Piwik::LABEL_ID_GOAL_IS_ECOMMERCE_ORDER);
@@ -302,6 +303,7 @@ class Pages
                     $widget->setName($report['name']);
                 }
                 $widget->setParameters($params);
+                $widget->addParameters($extraParameters);
                 $widget->setCategoryId($categoryText);
                 $widget->setSubcategoryId($categoryText);
                 $widget->setOrder($order);