Visit by hour should show report based on first action time (#13175)

* Visit by hour should show report based on first action time

Just a suggestion. IMO it is way more important to see at what hour you acquired specific users compared to when they dropped off. Especially if you are running certain ads for example etc. We could also add another report "first" and "last action" hour but I think that not both are actually needed and keeping it simple be better.

Performance wise this shouldn't have really any impact as the index be still used in the back by the where statement.

* fixed ui tests

* update screenshots

* update some expected files

* use first action time dimension

* update expected files

* update two more screenshots

1 files changed, 24 insertions, 24 deletions

diff --git a/plugins/Goals/tests/System/expected/test_trackGoals_allowMultipleConversionsPerVisit__VisitTime.getVisitInformationPerServerTime_day.xml b/plugins/Goals/tests/System/expected/test_trackGoals_allowMultipleConversionsPerVisit__VisitTime.getVisitInformationPerServerTime_day.xml
index 02554e3e24..a5df90f990 100644
--- a/plugins/Goals/tests/System/expected/test_trackGoals_allowMultipleConversionsPerVisit__VisitTime.getVisitInformationPerServerTime_day.xml
+++ b/plugins/Goals/tests/System/expected/test_trackGoals_allowMultipleConversionsPerVisit__VisitTime.getVisitInformationPerServerTime_day.xml
@@ -38,7 +38,7 @@
 		</goals>
 		<nb_conversions>8</nb_conversions>
 		<revenue>1332</revenue>
-		<segment>visitServerHour==0</segment>
+		<segment>visitStartServerHour==0</segment>
 	</row>
 	<row>
 		<label>01</label>
@@ -50,7 +50,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==1</segment>
+		<segment>visitStartServerHour==1</segment>
 	</row>
 	<row>
 		<label>02</label>
@@ -62,7 +62,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==2</segment>
+		<segment>visitStartServerHour==2</segment>
 	</row>
 	<row>
 		<label>03</label>
@@ -74,7 +74,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==3</segment>
+		<segment>visitStartServerHour==3</segment>
 	</row>
 	<row>
 		<label>04</label>
@@ -86,7 +86,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==4</segment>
+		<segment>visitStartServerHour==4</segment>
 	</row>
 	<row>
 		<label>05</label>
@@ -98,7 +98,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==5</segment>
+		<segment>visitStartServerHour==5</segment>
 	</row>
 	<row>
 		<label>06</label>
@@ -110,7 +110,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==6</segment>
+		<segment>visitStartServerHour==6</segment>
 	</row>
 	<row>
 		<label>07</label>
@@ -122,7 +122,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==7</segment>
+		<segment>visitStartServerHour==7</segment>
 	</row>
 	<row>
 		<label>08</label>
@@ -134,7 +134,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==8</segment>
+		<segment>visitStartServerHour==8</segment>
 	</row>
 	<row>
 		<label>09</label>
@@ -146,7 +146,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==9</segment>
+		<segment>visitStartServerHour==9</segment>
 	</row>
 	<row>
 		<label>10</label>
@@ -158,7 +158,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==10</segment>
+		<segment>visitStartServerHour==10</segment>
 	</row>
 	<row>
 		<label>11</label>
@@ -170,7 +170,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==11</segment>
+		<segment>visitStartServerHour==11</segment>
 	</row>
 	<row>
 		<label>12</label>
@@ -182,7 +182,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==12</segment>
+		<segment>visitStartServerHour==12</segment>
 	</row>
 	<row>
 		<label>13</label>
@@ -194,7 +194,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==13</segment>
+		<segment>visitStartServerHour==13</segment>
 	</row>
 	<row>
 		<label>14</label>
@@ -206,7 +206,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==14</segment>
+		<segment>visitStartServerHour==14</segment>
 	</row>
 	<row>
 		<label>15</label>
@@ -218,7 +218,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==15</segment>
+		<segment>visitStartServerHour==15</segment>
 	</row>
 	<row>
 		<label>16</label>
@@ -230,7 +230,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==16</segment>
+		<segment>visitStartServerHour==16</segment>
 	</row>
 	<row>
 		<label>17</label>
@@ -242,7 +242,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==17</segment>
+		<segment>visitStartServerHour==17</segment>
 	</row>
 	<row>
 		<label>18</label>
@@ -254,7 +254,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==18</segment>
+		<segment>visitStartServerHour==18</segment>
 	</row>
 	<row>
 		<label>19</label>
@@ -266,7 +266,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==19</segment>
+		<segment>visitStartServerHour==19</segment>
 	</row>
 	<row>
 		<label>20</label>
@@ -278,7 +278,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==20</segment>
+		<segment>visitStartServerHour==20</segment>
 	</row>
 	<row>
 		<label>21</label>
@@ -290,7 +290,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==21</segment>
+		<segment>visitStartServerHour==21</segment>
 	</row>
 	<row>
 		<label>22</label>
@@ -302,7 +302,7 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==22</segment>
+		<segment>visitStartServerHour==22</segment>
 	</row>
 	<row>
 		<label>23</label>
@@ -314,6 +314,6 @@
 		<sum_visit_length>0</sum_visit_length>
 		<bounce_count>0</bounce_count>
 		<nb_visits_converted>0</nb_visits_converted>
-		<segment>visitServerHour==23</segment>
+		<segment>visitStartServerHour==23</segment>
 	</row>
 </result>
\ No newline at end of file