Tweaking PingRequestProcessor, filling out missing docs and removing TODO from VisitTest.php.

1 files changed, 1 insertions, 9 deletions

diff --git a/plugins/Heartbeat/Tracker/PingRequestProcessor.php b/plugins/Heartbeat/Tracker/PingRequestProcessor.php
index 20144aa6f9..80e9759df8 100644
--- a/plugins/Heartbeat/Tracker/PingRequestProcessor.php
+++ b/plugins/Heartbeat/Tracker/PingRequestProcessor.php
@@ -19,22 +19,14 @@ use Piwik\Tracker\Visit\VisitProperties;
  */
 class PingRequestProcessor extends RequestProcessor
 {
-    public function processRequestParams(VisitProperties $visitProperties, Request $request)
+    public function afterRequestProcessed(VisitProperties $visitProperties, Request $request)
     {
         if ($this->isPingRequest($request)) {
             // on a ping request that is received before the standard visit length, we just update the visit time w/o adding a new action
             Common::printDebug("-> ping=1 request: we do not track a new action nor a new visit nor any goal.");
-
             $visitProperties->setRequestMetadata('Actions', 'action', null);
-        }
-    }
-
-    public function afterRequestProcessed(VisitProperties $visitProperties, Request $request)
-    {
-        if ($this->isPingRequest($request)) {
             $visitProperties->setRequestMetadata('Goals', 'someGoalsConverted', false);
             $visitProperties->setRequestMetadata('Goals', 'visitIsConverted', false);
-            // TODO: double check: can this be merged w/ setting action to null?
 
             // When a ping request is received more than 30 min after the last request/ping,
             // we choose not to create a new visit.