Ensure insight reports uses the correct compare period number for periods other than day (#15103)

1 files changed, 16 insertions, 1 deletions

diff --git a/plugins/Insights/Visualizations/Insight.php b/plugins/Insights/Visualizations/Insight.php
index 36b260b7ee..2835963615 100644
--- a/plugins/Insights/Visualizations/Insight.php
+++ b/plugins/Insights/Visualizations/Insight.php
@@ -49,7 +49,7 @@ class Insight extends Visualization
             'reportUniqueId' => $report,
             'minImpactPercent' => $this->requestConfig->min_impact_percent,
             'minGrowthPercent' => $this->requestConfig->min_growth_percent,
-            'comparedToXPeriods' => $this->requestConfig->compared_to_x_periods_ago,
+            'comparedToXPeriods' => $this->getComparedToXPeriodsAgo(),
             'orderBy'  => $this->requestConfig->order_by,
             'filterBy' => $this->requestConfig->filter_by,
             'pivotBy' => false,
@@ -59,6 +59,21 @@ class Insight extends Visualization
         );
     }
 
+    private function getComparedToXPeriodsAgo()
+    {
+        $period = Common::getRequestVar('period', null, 'string');
+
+        if ($period === 'month' && $this->requestConfig->compared_to_x_periods_ago > 1) {
+            return 12;
+        }
+
+        if ($period !== 'day') {
+            return 1;
+        }
+
+        return $this->requestConfig->compared_to_x_periods_ago;
+    }
+
     private function getLimitIncrease()
     {
         $filterLimit   = $this->requestConfig->filter_limit;