Use newer version of Puppeteer for UI tests (#17880)

* Use latest version of Puppeteer for UI tests

* use newer node on travis

* test

* use waitForTimeout / waitForSelector instead of waitFor

* Handle BC for removed waitFor method

* Updates expected UI test files

* update submodules

* improve/fix some UI tests

* Updates expected UI test files

* improve/fix some UI tests

* update url-parse dependency

* simplify some UI tests

* update screenshot

* avoid using merged assets that are broken

* fix expected compare exit code

* don't use merged assets for TwoFactorAuth UI tests

it seems due to too many requests to login, logout and other pages merging the CoreJS assets somehow fails, and results in returning an empty file. Even the reload fails to serve the correct content, so maybe the file, the content should be written to, is somehow locked. Disabling the merged assets seems to fix this issue for this tests. Locally the tests are also running correctly with merged assets.

* improve handling of automatic css / js reloading in UI tests

* increase timeouts of TwoFactorAuth UI tests

* fix 2fa ui test

* revert change

* update new screenshot

* updates UI screenshots

* submodule updates

9 files changed, 28 insertions, 28 deletions

diff --git a/plugins/Live/tests/UI/DeactivatedFeatures_spec.js b/plugins/Live/tests/UI/DeactivatedFeatures_spec.js
index 508dfbe26f..d98a38d730 100644
--- a/plugins/Live/tests/UI/DeactivatedFeatures_spec.js
+++ b/plugins/Live/tests/UI/DeactivatedFeatures_spec.js
@@ -48,7 +48,7 @@ describe("DeactivatedFeatures", function () {
     it('menu should contain visits log & realtime when enabled', async function () {
         await setFeatures(1, 0, 1);
         await page.goto("?module=CoreHome&action=index&idSite=1&period=year&date=2009-01-04#?idSite=1&period=year&date=2009-01-04&category=General_Visitors&subcategory=General_Overview");
-        await page.waitFor('#secondNavBar', {visible: true});
+        await page.waitForSelector('#secondNavBar', {visible: true});
 
         const vlog = await page.$('#secondNavBar .navbar a[href*="Live_VisitorLog"]');
         expect(vlog).to.be.ok;
@@ -63,7 +63,7 @@ describe("DeactivatedFeatures", function () {
     it('menu should not contain visits log & realtime when deactivated', async function () {
         await setFeatures(1, 1, 1);
         await page.reload();
-        await page.waitFor('#secondNavBar', {visible: true});
+        await page.waitForSelector('#secondNavBar', {visible: true});
 
         const vlog = await page.$('#secondNavBar .navbar a[href*="Live_VisitorLog"]');
         expect(vlog).to.be.not.ok;
@@ -102,7 +102,7 @@ describe("DeactivatedFeatures", function () {
     it('menu should contain ecommerce log when visits log enabled', async function () {
         await setFeatures(1, 0, 1);
         await page.goto("?module=CoreHome&action=index&idSite=1&period=year&date=2009-01-04#?idSite=1&period=year&date=2009-01-04&category=Goals_Ecommerce&subcategory=Goals_EcommerceLog");
-        await page.waitFor('#secondNavBar', {visible: true});
+        await page.waitForSelector('#secondNavBar', {visible: true});
 
         const element = await page.$('#secondNavBar .navbar a[href*="Goals_EcommerceLog"]');
         expect(element).to.be.ok;
@@ -111,7 +111,7 @@ describe("DeactivatedFeatures", function () {
     it('menu should not contain ecommerce log when visits log deactivated', async function () {
         await setFeatures(1, 1, 1);
         await page.reload();
-        await page.waitFor('#secondNavBar', {visible: true});
+        await page.waitForSelector('#secondNavBar', {visible: true});
 
         const element = await page.$('#secondNavBar .navbar a[href*="Goals_EcommerceLog"]');
         expect(element).to.be.not.ok;
@@ -128,7 +128,7 @@ describe("DeactivatedFeatures", function () {
     it('it should show profile link in visits log when enabled', async function () {
         await setFeatures(1, 0, 0);
         await page.goto("?module=CoreHome&action=index&idSite=1&period=year&date=2012-08-09#?idSite=1&period=year&date=2012-08-09&category=General_Visitors&subcategory=Live_VisitorLog");
-        await page.waitFor('.dataTableVizVisitorLog');
+        await page.waitForSelector('.dataTableVizVisitorLog');
 
         const element = await page.$('.dataTableVizVisitorLog .card .visitor-log-visitor-profile-link');
         expect(element).to.be.ok;
@@ -137,7 +137,7 @@ describe("DeactivatedFeatures", function () {
     it('it should not show profile link in visits log when disabled', async function () {
         await setFeatures(1, 0, 1);
         await page.reload();
-        await page.waitFor('.dataTableVizVisitorLog');
+        await page.waitForSelector('.dataTableVizVisitorLog');
 
         const element = await page.$('.dataTableVizVisitorLog .card .visitor-log-visitor-profile-link');
         expect(element).to.be.not.ok;
@@ -146,7 +146,7 @@ describe("DeactivatedFeatures", function () {
     it('it should show button to test new segments with enabled visits log', async function () {
         await setFeatures(1, 0, 1);
         await page.goto("?module=CoreHome&action=index&idSite=1&period=year&date=2012-07-09#?idSite=1&period=year&date=2012-07-09&category=General_Visitors&subcategory=General_Overview");
-        await page.waitFor('.segmentationContainer');
+        await page.waitForSelector('.segmentationContainer');
         await page.click('.segmentationContainer');
         await page.click('.add_new_segment');
 
@@ -157,7 +157,7 @@ describe("DeactivatedFeatures", function () {
     it('it should not show button to test new segments with disabled visits log', async function () {
         await setFeatures(1, 1, 1);
         await page.reload();
-        await page.waitFor('.segmentationContainer');
+        await page.waitForSelector('.segmentationContainer');
         await page.click('.segmentationContainer');
         await page.click('.add_new_segment');
 
@@ -171,7 +171,7 @@ describe("DeactivatedFeatures", function () {
         await page.waitForNetworkIdle();
 
         await (await page.jQuery('#widgetDevicesDetectiongetOsVersions td.label:first')).hover();
-        await page.waitFor('#widgetDevicesDetectiongetOsVersions .dataTableRowActions', {visible: true});
+        await page.waitForSelector('#widgetDevicesDetectiongetOsVersions .dataTableRowActions', {visible: true});
 
         const element = await page.$('#widgetDevicesDetectiongetOsVersions .dataTableRowActions .actionSegmentVisitorLog');
         expect(element).to.be.ok;
@@ -183,7 +183,7 @@ describe("DeactivatedFeatures", function () {
         await page.waitForNetworkIdle();
 
         await (await page.jQuery('#widgetDevicesDetectiongetOsVersions td.label:first')).hover();
-        await page.waitFor('#widgetDevicesDetectiongetOsVersions .dataTableRowActions', {visible: true});
+        await page.waitForSelector('#widgetDevicesDetectiongetOsVersions .dataTableRowActions', {visible: true});
 
         const element = await page.$('#widgetDevicesDetectiongetOsVersions .dataTableRowActions .actionSegmentVisitorLog');
         expect(element).to.be.not.ok;
@@ -195,7 +195,7 @@ describe("DeactivatedFeatures", function () {
         await page.waitForNetworkIdle();
 
         await (await page.jQuery('.widgetpreview-categorylist li:contains("Visitors"):first')).hover();
-        await page.waitFor('.widgetpreview-widgetlist', {visible: true});
+        await page.waitForSelector('.widgetpreview-widgetlist', {visible: true});
 
         const profile = await page.$('.widgetpreview-widgetlist [uniqueid=widgetLivegetVisitorProfilePopup]');
         expect(profile).to.be.ok;
@@ -216,7 +216,7 @@ describe("DeactivatedFeatures", function () {
         await page.waitForNetworkIdle();
 
         await (await page.jQuery('.widgetpreview-categorylist li:contains("Visitors"):first')).hover();
-        await page.waitFor('.widgetpreview-widgetlist', {visible: true});
+        await page.waitForSelector('.widgetpreview-widgetlist', {visible: true});
 
         const profile = await page.$('.widgetpreview-widgetlist [uniqueid=widgetLivegetVisitorProfilePopup]');
         expect(profile).to.be.not.ok;
@@ -234,7 +234,7 @@ describe("DeactivatedFeatures", function () {
     it('Goal overview contains segmented visitor log link when activated', async function () {
         await setFeatures(1, 0, 1);
         await page.goto("?module=CoreHome&action=index&idSite=1&period=year&date=2012-08-08#?idSite=1&period=year&date=2012-08-08&category=Goals_Goals&subcategory=1");
-        await page.waitFor('#widgetGoalsgoalConversionsOverviewidGoal1', {visible: true});
+        await page.waitForSelector('#widgetGoalsgoalConversionsOverviewidGoal1', {visible: true});
 
         const profile = await page.$('#widgetGoalsgoalConversionsOverviewidGoal1 a.segmentedlog');
         expect(profile).to.be.ok;
@@ -243,7 +243,7 @@ describe("DeactivatedFeatures", function () {
     it('Goal overview does not contain segmented visitor log link when disabled', async function () {
         await setFeatures(1, 1, 1);
         await page.reload();
-        await page.waitFor('#widgetGoalsgoalConversionsOverviewidGoal1', {visible: true});
+        await page.waitForSelector('#widgetGoalsgoalConversionsOverviewidGoal1', {visible: true});
 
         const profile = await page.$('#widgetGoalsgoalConversionsOverviewidGoal1 a.segmentedlog');
         expect(profile).to.be.not.ok;
@@ -305,7 +305,7 @@ describe("DeactivatedFeatures", function () {
     it('menu should not contain visits log when deactivated globally', async function () {
         await setConfig(1, 1);
         await page.goto("?module=CoreHome&action=index&idSite=1&period=year&date=2009-01-04#?idSite=1&period=year&date=2009-01-04&category=General_Visitors&subcategory=General_Overview");
-        await page.waitFor('#secondNavBar', {visible: true});
+        await page.waitForSelector('#secondNavBar', {visible: true});
 
         const element = await page.$('#secondNavBar .navbar a[href*="Live_VisitorLog"]');
         expect(element).to.be.not.ok;
diff --git a/plugins/Live/tests/UI/Live_spec.js b/plugins/Live/tests/UI/Live_spec.js
index 9e0ba37874..d31d470c6c 100644
--- a/plugins/Live/tests/UI/Live_spec.js
+++ b/plugins/Live/tests/UI/Live_spec.js
@@ -21,7 +21,7 @@ describe("Live", function () {
         await page.goto("?module=CoreHome&action=index&idSite=1&period=year&date=2010-01-03#?idSite=1&period=year&date=2010-01-03&category=General_Visitors&subcategory=Live_VisitorLog");
 
         await page.waitForNetworkIdle();
-        await page.waitFor('.dataTableVizVisitorLog');
+        await page.waitForSelector('.dataTableVizVisitorLog');
 
         var report = await page.$('.reporting-page');
         expect(await report.screenshot()).to.matchImage('visitor_log');
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log.png
index 7e03b3f7c4..50c5d91ecd 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:fa1d5a108f3089599ccdb091f89e779b6a032327d16aaefe84ce94e2ac06321c
-size 386172
+oid sha256:5a606dc50663830984e0e30edb727860db7de042c9241e625009923210b89196
+size 386185
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_actions.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_actions.png
index dda52a344b..8264bbfaa6 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_actions.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_actions.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9a77301420974e3f3194c752116bf22c6cd75882ad638f245efc048631374632
-size 51599
+oid sha256:f0086120e8f9548298357d45ffec30ceb507701687009fc69b9f64917388b970
+size 51598
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_content_actions.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_content_actions.png
index 710eda75ee..701c3d9152 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_content_actions.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_content_actions.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ef5b12f774f5934f05b82e972ac8df8ee7ae3376e446aef3b5f6896657df32be
-size 39891
+oid sha256:d9bd76f258af9a88e0cf58090d49593d5e4328d4c788d1e94d19a61d70d7797e
+size 39886
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_pageview_actions.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_pageview_actions.png
index e686666fef..bb3c6f5196 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_pageview_actions.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_log_expand_pageview_actions.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:2bbd83ebe4e1ba806261871abf562b27743ace121064c5ec143fc8b64e331eeb
-size 102070
+oid sha256:a1b8136cf7a0607857f929eddafd7eaa2719284e94d99434e08ca4b5bde6034f
+size 102065
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile.png
index df19c3ecb6..96bf7578de 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:28054cad7ff7bc20b613371a3ac9fe41dc2c36f7f5b2998ff508f8dad82ddc0c
-size 423220
+oid sha256:87dfa7cbb02b66ff0ae21baf441e80cc612a45f3abb45ee533deef3839636132
+size 423221
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_limited.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_limited.png
index b2561c1d7b..69407fc7f8 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_limited.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_limited.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:7c2ddc545cc4767795cf9b4cecea826f9018be6353eae7e2a76c2ce20747dd8a
+oid sha256:1e8980055f55066eed4f95bfb2e40e293a953a2478ca18ac15c2a7db3192dd7c
 size 311397
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_more_visits.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_more_visits.png
index d5c441a312..1545c63998 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_more_visits.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_more_visits.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9970312f1e90aaaeb333b100855f6d6c4f4164cc32abf40b40bd544f5e874e2c
+oid sha256:69241c8e7ab81203abf8faffcb241616151ba000afa093a4efc052b04aba9408
 size 449462