Switch from bower to npm and update JS libraries (#14082)

* Starting to replace bower with npm: use updated jquery-ui from npm.

* Use jquery from npm./

* Use angular from npm.

* Add more angular libraries.

* Use chroma-js from npm.

* Remove html5shiv, does not appear to be used.

* Use iframe resizer library from npm.

* Add jquery-mousewheel

* Add jquery.dotdotdot from npm.

* Get jquery.scrollto from npm.

* Get jscrollpane from npm.

* Get materialize-css from npm.

* Get mousetrap from npm.

* Remove ngDialog, as it is no longer used.

* Install qrcode.js from npm.

* Get sprintf-js from npm.

* Get visibillityjs from npm.

* Remove bower.json.

* Getting parts of matomo to work w/ new versions of libraries installed by npm.

* Ignore node_modules subfolders in node_modules since we only use npm for frontend dependencies + fix a test.

* Fix button padding.

* Fix series picker checkboxes.

* Fix karma conf.

* Fix CSS in right place.

* Fixing more css/less issues.

* More test fixes.

* Limit selection style fix.

* Fix more tests + materializecss issues.

* Fix a couple more tests.

* Fix annotation styling.

* remove error

* add ng-dialog files

* try to fix some tests

* Fix several UI tests.

* fixing more build issues

* Fix several more tests and issues.

* fixing more tests

* split ui tests into 3 groups

* fix several more issues and tests

* Fix some console warnings on chrome.

* Updating more test files.

* fix some tests

* yet more fixes

* couple more fixes

* another form fix

* Fix some tests.

* update screenshot

* update more expected files

* Fix two more form issues.

* test commit (travis is not fetching submodules for some reason...)

* remove scripts removed in merge

* three travis builds

* split UIIntegrationTest into multiple suites

* lets try this again

* updae several expected screenshots

* fix some more tests

* fix plugin details material select and tabs initiaialization

* update screenshots + css fix

* re-initialize materialize tabs since we load jquery-ui afterwards for datepicker which unsets materialize tabs

* update more screenshots and fix couple more issues

* update more screenshots + tweak to test

* more fixes and screenshot updates

* fix some issues and update more screenshots

* update submodules

* more fixes + more updated screenshots

* more css fixes and test fixes

* couple fixes & updated screenshots

* update screenshots

* fix random failure

* Map old bower_component files to new ones in AssetManager.

* Remove node_modules from PR and ignore node_modules in .gitignore and remove libs/jquery (adding new required libs).

* Update .travis.yml.

* update screenshots

* fixing some more issues

* fix copy pasta

* update screenshots

* fix more modal issues

* Update css & screenshots.

* correct close modal calls

* fixing more issues

* data-target instead of data-activates

* fix more tests

* trigger build that works?

* fix more tests

* update submodule

* debugging travis

* more debugging

* try to fix test

* fix modal no button click in test

* update more screenshots

* couple more test fixes

* some more fixes and updated screenshots

* update screenshots

* apply some review feedback

* Fix modal centering and initial top position.

* apply some more pr feedback

* another pr fix

* update submodule

* remove style

* fix color of checkbox mark

* Fix centering the popover

Note: centering the popover relative to body doesn't work poperly anymore, maybe because of the fixed position of the widget overlay. Using the ui-widget-overlay to position the dialog centered seems to work

* ignore line endings check for node modules

* updates expected UI files

* submodule updates

* use minified file of jquery.browser.js

* updates expected test files

* ensure to hide parent tooltips when row action tooltips are shown

* tweak less for datatable navigation

* style is only useful for dashboard

* update some screenshots

* update submodules

Co-authored-by: sgiehl <stefan@matomo.org>

9 files changed, 19 insertions, 13 deletions

diff --git a/plugins/Live/Live.php b/plugins/Live/Live.php
index f5f7cb1c4e..855ed752fa 100644
--- a/plugins/Live/Live.php
+++ b/plugins/Live/Live.php
@@ -60,7 +60,7 @@ class Live extends \Piwik\Plugin
 
     public function getJsFiles(&$jsFiles)
     {
-        $jsFiles[] = "libs/bower_components/visibilityjs/lib/visibility.core.js";
+        $jsFiles[] = "node_modules/visibilityjs/lib/visibility.core.js";
         $jsFiles[] = "plugins/Live/javascripts/live.js";
         $jsFiles[] = "plugins/Live/javascripts/SegmentedVisitorLog.js";
         $jsFiles[] = "plugins/Live/javascripts/visitorActions.js";
diff --git a/plugins/Live/stylesheets/live.less b/plugins/Live/stylesheets/live.less
index 9a0e4730a6..5f121dce8c 100644
--- a/plugins/Live/stylesheets/live.less
+++ b/plugins/Live/stylesheets/live.less
@@ -387,6 +387,11 @@ ol.visitorLog p {
 
 .dataTableVizVisitorLog {
 
+  .card.row {
+    margin-left: 0;
+    margin-right: 0;
+  }
+
   .card {
     padding: 15px 0;
     font-size: 13px;
diff --git a/plugins/Live/stylesheets/visitor_profile.less b/plugins/Live/stylesheets/visitor_profile.less
index b60ecbc885..d8e0ccbd12 100644
--- a/plugins/Live/stylesheets/visitor_profile.less
+++ b/plugins/Live/stylesheets/visitor_profile.less
@@ -342,6 +342,7 @@
   color: @theme-color-text;
   cursor: pointer;
   background-color: @color-silver-l95;
+  margin-right: 2px;
 
   &:hover {
     background-color: #bfbfbf;
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile.png
index bc80f60cfc..465c57a732 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:f6d9430573d5ccfa8bcbfa5c42118dac73d078904e2ff9bfed305e33659680c2
-size 418209
+oid sha256:0fd576f89fd7139b2b99cc3d74bb53a24a1eb504367345147e872eb3683e4d7d
+size 420703
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_action_details.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_action_details.png
index 8029187c5b..2e6ba484f6 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_action_details.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_action_details.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:8a88a1bdfd0d14ae3b00c9627ff62e1b696daa7f2fade019e4f275daf6713a9d
-size 294504
+oid sha256:4157f3c20d56c69196f6c26e238deec778af0c8deccab2789fb908a72ab60ccf
+size 295467
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_actions_hidden.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_actions_hidden.png
index 219f74b164..14602039ba 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_actions_hidden.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_actions_hidden.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:4ce98d7c88cc0c96ad7705d0b6cfc6de61cb1d79985057fa609debd589c0991a
-size 260536
+oid sha256:a86335642665ca83cc69bd8959ee4a008b49685fac4c27f395af3a881c06459b
+size 261466
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_limited.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_limited.png
index af61c3cd70..aef56d4c49 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_limited.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_limited.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:79e1954b46ed0670a56a720cfef1f4d99b31ef51562ae61f0a4c67db8a03900e
-size 310152
+oid sha256:634cf1607afff06b53f8271a396609f99007b6f232b3180737f18134f002c59d
+size 311307
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_more_visits.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_more_visits.png
index 41a509e144..5b96cd2aab 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_more_visits.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_more_visits.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:a160b52491bcf67df211b8154811540a90dcc25ba563f5ee6fb53327594e0401
-size 443899
+oid sha256:9ad04b14e25cde7e7f652ed85062234c5262bb69ee5fdcac4db60ef73e480e00
+size 446995
diff --git a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_visit_details.png b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_visit_details.png
index 0cb5fd0da0..784fa33af7 100644
--- a/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_visit_details.png
+++ b/plugins/Live/tests/UI/expected-screenshots/Live_visitor_profile_visit_details.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:f0043c49ef3cda849ce7f9aade26f38339542f2d897647d9623ca35e9929747c
-size 270115
+oid sha256:2f5dd1cac6c258501d45b1b453894d3c6c7cb2d99fd031b895ab48e3deb0c2dc
+size 271129