Implemented custom event dispatching system for Piwik (replaced event dispatcher lib in libs/Event).

Notes:
  - New dispatcher can execute callbacks before or after other callbacks.
  - It is also possible to dispatch events only to a specific set of plugins instead of all plugins.
  - Moved Piwik::unprefixClass to Piwik_Common::unprefixClass
  - Added visibility to some event handlers that were missing it.
  - Allowed two unit tests to fail w/ better diagnostic messages.

1 files changed, 3 insertions, 18 deletions

diff --git a/plugins/MultiSites/MultiSites.php b/plugins/MultiSites/MultiSites.php
index aa23d48040..6d3f65af77 100644
--- a/plugins/MultiSites/MultiSites.php
+++ b/plugins/MultiSites/MultiSites.php
@@ -35,10 +35,7 @@ class Piwik_MultiSites extends Piwik_Plugin
         );
     }
 
-    /**
-     * @param Piwik_Event_Notification $notification  notification object
-     */
-    public function getReportMetadata($notification)
+    public function getReportMetadata(&$reports)
     {
         $metadataMetrics = array();
         foreach (Piwik_MultiSites_API::getApiMetrics($enhanced = true) as $metricName => $metricSettings) {
@@ -48,8 +45,6 @@ class Piwik_MultiSites extends Piwik_Plugin
                 Piwik_Translate($metricSettings[Piwik_MultiSites_API::METRIC_TRANSLATION_KEY]) . " " . Piwik_Translate('MultiSites_Evolution');
         }
 
-        $reports = & $notification->getNotificationObject();
-
         $reports[] = array(
             'category'          => Piwik_Translate('General_MultiSitesSummary'),
             'name'              => Piwik_Translate('General_AllWebsitesDashboard'),
@@ -82,23 +77,13 @@ class Piwik_MultiSites extends Piwik_Plugin
         Piwik_AddTopMenu('General_MultiSitesSummary', $urlParams, true, 3, $isHTML = false, $tooltip);
     }
 
-    /**
-     * @param Piwik_Event_Notification $notification  notification object
-     */
-    function getJsFiles($notification)
+    public function getJsFiles(&$jsFiles)
     {
-        $jsFiles = & $notification->getNotificationObject();
-
         $jsFiles[] = "plugins/MultiSites/javascripts/multiSites.js";
     }
 
-    /**
-     * @param Piwik_Event_Notification $notification  notification object
-     */
-    function getCssFiles($notification)
+    public function getCssFiles(&$cssFiles)
     {
-        $cssFiles = & $notification->getNotificationObject();
-
         $cssFiles[] = "plugins/MultiSites/stylesheets/multiSites.css";
     }
 }