diff options
author | Thomas Steur <thomas.steur@googlemail.com> | 2014-07-07 04:14:08 +0400 |
---|---|---|
committer | Thomas Steur <thomas.steur@googlemail.com> | 2014-07-07 04:14:08 +0400 |
commit | 4f4b98eeb5eb322d7423f72fb78c80d18878313e (patch) | |
tree | 825d3a924b98be6263e2230a9dc69f4621fe6179 /plugins/Referrers | |
parent | 76e11c5b11806bc9130b90424eb2254aa8b061e6 (diff) |
If a dimension only implements a getName() method it should extend Dimension and not VisitDimension which is more "correct" and improves performance since we do not have to check whether they are installed and whether they implement certain methods
Diffstat (limited to 'plugins/Referrers')
-rw-r--r-- | plugins/Referrers/Columns/Campaign.php | 4 | ||||
-rw-r--r-- | plugins/Referrers/Columns/Referrer.php | 4 | ||||
-rw-r--r-- | plugins/Referrers/Columns/SearchEngine.php | 4 | ||||
-rw-r--r-- | plugins/Referrers/Columns/Socialnetwork.php | 4 | ||||
-rw-r--r-- | plugins/Referrers/Columns/Website.php | 4 | ||||
-rw-r--r-- | plugins/Referrers/Columns/WebsitePage.php | 4 |
6 files changed, 12 insertions, 12 deletions
diff --git a/plugins/Referrers/Columns/Campaign.php b/plugins/Referrers/Columns/Campaign.php index 0c5a9bf387..4413cd702f 100644 --- a/plugins/Referrers/Columns/Campaign.php +++ b/plugins/Referrers/Columns/Campaign.php @@ -8,10 +8,10 @@ */ namespace Piwik\Plugins\Referrers\Columns; +use Piwik\Columns\Dimension; use Piwik\Piwik; -use Piwik\Plugin\Dimension\VisitDimension; -class Campaign extends VisitDimension +class Campaign extends Dimension { public function getName() { diff --git a/plugins/Referrers/Columns/Referrer.php b/plugins/Referrers/Columns/Referrer.php index c72f75d37d..ac22e6f5c9 100644 --- a/plugins/Referrers/Columns/Referrer.php +++ b/plugins/Referrers/Columns/Referrer.php @@ -8,10 +8,10 @@ */ namespace Piwik\Plugins\Referrers\Columns; +use Piwik\Columns\Dimension; use Piwik\Piwik; -use Piwik\Plugin\Dimension\VisitDimension; -class Referrer extends VisitDimension +class Referrer extends Dimension { public function getName() { diff --git a/plugins/Referrers/Columns/SearchEngine.php b/plugins/Referrers/Columns/SearchEngine.php index cc8d6bed23..4c2a0740e8 100644 --- a/plugins/Referrers/Columns/SearchEngine.php +++ b/plugins/Referrers/Columns/SearchEngine.php @@ -8,10 +8,10 @@ */ namespace Piwik\Plugins\Referrers\Columns; +use Piwik\Columns\Dimension; use Piwik\Piwik; -use Piwik\Plugin\Dimension\VisitDimension; -class SearchEngine extends VisitDimension +class SearchEngine extends Dimension { public function getName() { diff --git a/plugins/Referrers/Columns/Socialnetwork.php b/plugins/Referrers/Columns/Socialnetwork.php index 7e52846cc1..62ce964c37 100644 --- a/plugins/Referrers/Columns/Socialnetwork.php +++ b/plugins/Referrers/Columns/Socialnetwork.php @@ -8,10 +8,10 @@ */ namespace Piwik\Plugins\Referrers\Columns; +use Piwik\Columns\Dimension; use Piwik\Piwik; -use Piwik\Plugin\Dimension\VisitDimension; -class SocialNetwork extends VisitDimension +class SocialNetwork extends Dimension { public function getName() { diff --git a/plugins/Referrers/Columns/Website.php b/plugins/Referrers/Columns/Website.php index 7faf5646c5..e0ce2b2845 100644 --- a/plugins/Referrers/Columns/Website.php +++ b/plugins/Referrers/Columns/Website.php @@ -8,10 +8,10 @@ */ namespace Piwik\Plugins\Referrers\Columns; +use Piwik\Columns\Dimension; use Piwik\Piwik; -use Piwik\Plugin\Dimension\VisitDimension; -class Website extends VisitDimension +class Website extends Dimension { public function getName() { diff --git a/plugins/Referrers/Columns/WebsitePage.php b/plugins/Referrers/Columns/WebsitePage.php index 51c1aac5ca..5ac2bc63f3 100644 --- a/plugins/Referrers/Columns/WebsitePage.php +++ b/plugins/Referrers/Columns/WebsitePage.php @@ -8,10 +8,10 @@ */ namespace Piwik\Plugins\Referrers\Columns; +use Piwik\Columns\Dimension; use Piwik\Piwik; -use Piwik\Plugin\Dimension\VisitDimension; -class WebsitePage extends VisitDimension +class WebsitePage extends Dimension { public function getName() { |