Update PHP extension requirements & deprecate Common::mb_* methods (#16754)

* Require polyfill for mbstring and iconv

* remove mbstring methods from upgrade.php

* remove checks for some php extensions

* deprecate Common::mb_* methods, as we can directly use mb_* functions instead

* updates expected test files

* Directly use mb_* methods in favor of Common::mb_*

* Update expected screenshot

Co-authored-by: diosmosis <diosmosis@users.noreply.github.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/plugins/ScheduledReports/Controller.php b/plugins/ScheduledReports/Controller.php
index 3e79e35beb..8f60a4093a 100644
--- a/plugins/ScheduledReports/Controller.php
+++ b/plugins/ScheduledReports/Controller.php
@@ -40,7 +40,7 @@ class Controller extends \Piwik\Plugin\Controller
         $reportTypes = API::getReportTypes();
         $reportTypeOptions = array();
         foreach ($reportTypes as $reportType => $icon) {
-            $reportTypeOptions[$reportType] = Common::mb_strtoupper($reportType);
+            $reportTypeOptions[$reportType] = mb_strtoupper($reportType);
         }
         $view->reportTypes = $reportTypes;
         $view->reportTypeOptions = $reportTypeOptions;
@@ -67,7 +67,7 @@ class Controller extends \Piwik\Plugin\Controller
             $reportFormatsByReportType[$reportType] = API::getReportFormats($reportType);
             $reportFormatsByReportTypeOptions[$reportType] = $reportFormatsByReportType[$reportType];
             foreach ($reportFormatsByReportTypeOptions[$reportType] as $type => $icon) {
-                $reportFormatsByReportTypeOptions[$reportType][$type] = Common::mb_strtoupper($type);
+                $reportFormatsByReportTypeOptions[$reportType][$type] = mb_strtoupper($type);
             }
             $allowMultipleReportsByReportType[$reportType] = API::allowMultipleReports($reportType);