diff options
| author | Stefan Giehl <stefan@matomo.org> | 2021-05-27 04:58:30 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-27 04:58:30 +0300 |
| commit | c973567705a0065fdd7d7c7b11b80f1f0f1be350 (patch) | |
| tree | 89947dbce864ac48389c742fce31d30106eebada /plugins/SegmentEditor | |
| parent | 70b05de003487a31495bb9927017606a2faab7dd (diff) | |
Update PHP extension requirements & deprecate Common::mb_* methods (#16754)
* Require polyfill for mbstring and iconv
* remove mbstring methods from upgrade.php
* remove checks for some php extensions
* deprecate Common::mb_* methods, as we can directly use mb_* functions instead
* updates expected test files
* Directly use mb_* methods in favor of Common::mb_*
* Update expected screenshot
Co-authored-by: diosmosis <diosmosis@users.noreply.github.com>
Diffstat (limited to 'plugins/SegmentEditor')
| -rw-r--r-- | plugins/SegmentEditor/SegmentFormatter.php | 2 | ||||
| -rw-r--r-- | plugins/SegmentEditor/SegmentSelectorControl.php | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/plugins/SegmentEditor/SegmentFormatter.php b/plugins/SegmentEditor/SegmentFormatter.php index 67c791b467..fe0ef7eac8 100644 --- a/plugins/SegmentEditor/SegmentFormatter.php +++ b/plugins/SegmentEditor/SegmentFormatter.php @@ -110,7 +110,7 @@ class SegmentFormatter $translation = Piwik::translate($this->matchesMetric[$operator]); } - return Common::mb_strtolower($translation); + return mb_strtolower($translation); } private function getFormattedValue($operand) diff --git a/plugins/SegmentEditor/SegmentSelectorControl.php b/plugins/SegmentEditor/SegmentSelectorControl.php index 411209f1b9..6aec61c51f 100644 --- a/plugins/SegmentEditor/SegmentSelectorControl.php +++ b/plugins/SegmentEditor/SegmentSelectorControl.php @@ -56,7 +56,7 @@ class SegmentSelectorControl extends UIControl if ($segment['category'] == $visitTitle && ($segment['type'] == 'metric' && $segment['segment'] != 'visitIp') ) { - $metricsLabel = Common::mb_strtolower(Piwik::translate('General_Metrics')); + $metricsLabel = mb_strtolower(Piwik::translate('General_Metrics')); $segment['category'] .= ' (' . $metricsLabel . ')'; } $segmentsByCategory[$segment['category']][] = $segment; |