Add diagnostic to check last time archiving was run successfully and … (#13972)

* Add diagnostic to check last time archiving was run successfully and display notification if empty report and archiving has not been run recently.

* Move cron archiving diagnostics next to each other.

* Add new test for archiving not done in time check.

* Remove TODO comment.

1 files changed, 6 insertions, 0 deletions

diff --git a/plugins/SegmentEditor/SegmentEditor.php b/plugins/SegmentEditor/SegmentEditor.php
index 7d7d7d1b8c..2e03343bd8 100644
--- a/plugins/SegmentEditor/SegmentEditor.php
+++ b/plugins/SegmentEditor/SegmentEditor.php
@@ -17,6 +17,7 @@ use Piwik\DataAccess\ArchiveSelector;
 use Piwik\Notification;
 use Piwik\Piwik;
 use Piwik\Plugins\CoreHome\SystemSummary;
+use Piwik\Plugins\Diagnostics\Diagnostics;
 use Piwik\Segment;
 use Piwik\SettingsPiwik;
 use Piwik\SettingsServer;
@@ -115,6 +116,11 @@ class SegmentEditor extends \Piwik\Plugin
 
     public function onNoData(View $dataTableView)
     {
+        // if the archiving hasn't run in a while notification is up, don't display this one
+        if (isset($dataTableView->notifications[Diagnostics::NO_DATA_ARCHIVING_NOT_RUN_NOTIFICATION_ID])) {
+            return;
+        }
+
         $segmentInfo = $this->getSegmentIfIsUnprocessed();
         if (empty($segmentInfo)) {
             return;