diff options
| author | diosmosis <diosmosis@users.noreply.github.com> | 2019-07-16 07:33:25 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-07-16 07:33:25 +0300 |
| commit | e4c1f1f92114ca03947e9932935e4b4195ae1604 (patch) | |
| tree | 86d3f38165ee87eb4c7f8a36dc8bdb779c04fb22 /plugins/SegmentEditor | |
| parent | 75c4c9d3a8be5b9d035f086c3b2edb45afaed61a (diff) | |
Keep top level nb_visits_converted metric (#14253)
* Do not remove nb_visits_converted when archiving goal reports since it should differ from sum of conversions.
* If metric is not available, compute dynamically by using max nb_visits_converted.
* Ignore abandoned cart conversions when calculating visit converted.
* In case goals column is empty.
* remove processed metric code since it is not correct
* do not remove visits converted metric for overview
* fix tests
* Fixing test
* fix test
* update test files
* update submodules
* Update expected screenshots & try to fix some random failures.
* Update expected UI test export results.
* two ui test fixes
* Fix couple UI test failures.
* fix random php test failure
Diffstat (limited to 'plugins/SegmentEditor')
| -rw-r--r-- | plugins/SegmentEditor/tests/UI/SegmentSelectorEditor_spec.js | 2 | ||||
| -rw-r--r-- | plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_suggested_values.png | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/plugins/SegmentEditor/tests/UI/SegmentSelectorEditor_spec.js b/plugins/SegmentEditor/tests/UI/SegmentSelectorEditor_spec.js index ccef0d4d03..8477f42b6c 100644 --- a/plugins/SegmentEditor/tests/UI/SegmentSelectorEditor_spec.js +++ b/plugins/SegmentEditor/tests/UI/SegmentSelectorEditor_spec.js @@ -94,7 +94,7 @@ describe("SegmentSelectorEditorTest", function () { it("should show suggested segment values when a segment value input is focused", async function() { await page.click('.segmentEditorPanel .segmentRow0 .ui-autocomplete-input'); await page.waitForNetworkIdle(); - await page.waitFor(250); + await page.waitFor(500); expect(await page.screenshotSelector(selectorsToCapture)).to.matchImage('suggested_values'); }); diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_suggested_values.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_suggested_values.png index b6b612b5a5..5cac8c7924 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_suggested_values.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_suggested_values.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:14d28c45f38f021b7b8373b563f9b6f1740737edb1e943ea05f557f65caf80bf -size 34809 +oid sha256:fd0bf164f65454272cda6e97e3f9d7ec72a7a75934bdb2b59c011f414c3a1c9d +size 55067 |
