diff options
| author | diosmosis <diosmosis@users.noreply.github.com> | 2019-07-16 07:33:25 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-07-16 07:33:25 +0300 |
| commit | e4c1f1f92114ca03947e9932935e4b4195ae1604 (patch) | |
| tree | 86d3f38165ee87eb4c7f8a36dc8bdb779c04fb22 /plugins/Transitions | |
| parent | 75c4c9d3a8be5b9d035f086c3b2edb45afaed61a (diff) | |
Keep top level nb_visits_converted metric (#14253)
* Do not remove nb_visits_converted when archiving goal reports since it should differ from sum of conversions.
* If metric is not available, compute dynamically by using max nb_visits_converted.
* Ignore abandoned cart conversions when calculating visit converted.
* In case goals column is empty.
* remove processed metric code since it is not correct
* do not remove visits converted metric for overview
* fix tests
* Fixing test
* fix test
* update test files
* update submodules
* Update expected screenshots & try to fix some random failures.
* Update expected UI test export results.
* two ui test fixes
* Fix couple UI test failures.
* fix random php test failure
Diffstat (limited to 'plugins/Transitions')
| -rw-r--r-- | plugins/Transitions/tests/UI/Transitions_spec.js | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/plugins/Transitions/tests/UI/Transitions_spec.js b/plugins/Transitions/tests/UI/Transitions_spec.js index 576cd416c1..0738a0f35c 100644 --- a/plugins/Transitions/tests/UI/Transitions_spec.js +++ b/plugins/Transitions/tests/UI/Transitions_spec.js @@ -33,6 +33,7 @@ describe("Transitions", function () { await (await page.jQuery('a.actionTransitions:visible')).click(); await page.waitForNetworkIdle(); + await page.waitFor('.ui-dialog', { visible: true }); expect(await page.screenshotSelector('.ui-dialog')).to.matchImage('transitions_popup_titles'); }); |