* Enabling Twig 'strict_variables' so that we write best code possible, and learn early if some tpl code is not valid. Fixing few bugs that this uncovered

* refactoring the percent column label in getPercentVisitColumn()
* removing indexBeforeMenu and putting directly in parent template
Refs #4019

2 files changed, 2 insertions, 2 deletions

diff --git a/plugins/VisitorInterest/Controller.php b/plugins/VisitorInterest/Controller.php
index 1ee0d7755c..e2b9936c7f 100644
--- a/plugins/VisitorInterest/Controller.php
+++ b/plugins/VisitorInterest/Controller.php
@@ -73,7 +73,7 @@ class Piwik_VisitorInterest_Controller extends Piwik_Controller
         $view->setColumnsToDisplay(array('label', 'nb_visits', 'nb_visits_percentage'));
         $view->setSortedColumn('label', 'asc');
         $view->setColumnTranslation('label', Piwik_Translate('VisitorInterest_VisitNum'));
-        $view->setColumnTranslation('nb_visits_percentage', str_replace(' ', ' ', Piwik_Translate('General_ColumnPercentageVisits')));
+        $view->setColumnTranslation('nb_visits_percentage', Piwik_Metrics::getPercentVisitColumn());
         $view->disableExcludeLowPopulation();
         $view->disableOffsetInformationAndPaginationControls();
         $view->disableShowAllViewsIcons();
diff --git a/plugins/VisitorInterest/VisitorInterest.php b/plugins/VisitorInterest/VisitorInterest.php
index c2a46f1f9e..d17750a662 100644
--- a/plugins/VisitorInterest/VisitorInterest.php
+++ b/plugins/VisitorInterest/VisitorInterest.php
@@ -80,7 +80,7 @@ class Piwik_VisitorInterest extends Piwik_Plugin
             'dimension'         => Piwik_Translate('VisitorInterest_visitsByVisitCount'),
             'metrics'           => array(
                 'nb_visits',
-                'nb_visits_percentage' => Piwik_Translate('General_ColumnPercentageVisits')
+                'nb_visits_percentage' => Piwik_Metrics::getPercentVisitColumn(),
             ),
             'processedMetrics'  => false,
             'constantRowsCount' => true,