Make MetricsFormatter a class with instance methods and move Html related functionality to derived class. Use FOrmatter in Metric::format calls so Metrics do not have to be aware of context of formatting, and so Metric::format methods will have less code redundancy.

1 files changed, 5 insertions, 4 deletions

diff --git a/plugins/VisitsSummary/API.php b/plugins/VisitsSummary/API.php
index 0530fd7ae3..8207e23bb6 100644
--- a/plugins/VisitsSummary/API.php
+++ b/plugins/VisitsSummary/API.php
@@ -9,8 +9,7 @@
 namespace Piwik\Plugins\VisitsSummary;
 
 use Piwik\Archive;
-use Piwik\Common;
-use Piwik\MetricsFormatter;
+use Piwik\Metrics\Formatter;
 use Piwik\Piwik;
 use Piwik\Plugin\Report;
 use Piwik\SettingsPiwik;
@@ -119,12 +118,14 @@ class API extends \Piwik\Plugin\API
 
     public function getSumVisitsLengthPretty($idSite, $period, $date, $segment = false)
     {
+        $formatter = new Formatter();
+
         $table = $this->getSumVisitsLength($idSite, $period, $date, $segment);
         if (is_object($table)) {
             $table->filter('ColumnCallbackReplace',
-                array('sum_visit_length', '\Piwik\MetricsFormatter::getPrettyTimeFromSeconds'));
+                array('sum_visit_length', array($formatter, 'getPrettyTimeFromSeconds')));
         } else {
-            $table = MetricsFormatter::getPrettyTimeFromSeconds($table);
+            $table = $formatter->getPrettyTimeFromSeconds($table);
         }
         return $table;
     }