Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/matomo-org/matomo.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Vilk <jvilk@cs.umass.edu>2017-12-15 02:55:13 +0300
committerThomas Steur <tsteur@users.noreply.github.com>2017-12-15 02:55:13 +0300
commitd647d5c99ea4cf46bfbb699ae67ae84ba0982af7 (patch)
tree6cfe94b9f5c7b5baa3e55a4cb1684b379d1253ec /plugins
parenteca358198731bcc708bd3fe68f293c3f793da6d6 (diff)
Fixes memory leak in piwikApiService. (#12249)
Fixes #12105.
Diffstat (limited to 'plugins')
-rw-r--r--plugins/CoreHome/angularjs/common/services/piwik-api.js8
1 files changed, 6 insertions, 2 deletions
diff --git a/plugins/CoreHome/angularjs/common/services/piwik-api.js b/plugins/CoreHome/angularjs/common/services/piwik-api.js
index 65127ece8a..30cb872a9a 100644
--- a/plugins/CoreHome/angularjs/common/services/piwik-api.js
+++ b/plugins/CoreHome/angularjs/common/services/piwik-api.js
@@ -168,8 +168,12 @@ var hasBlockedContent = false;
var request = addAbortMethod(promise, deferred);
allRequests.push(request);
-
- return request;
+ return request.finally(function() {
+ var index = allRequests.indexOf(request);
+ if (index !== -1) {
+ allRequests.splice(index, 1);
+ }
+ });
}
/**