diff options
author | Matthieu Napoli <matthieu@mnapoli.fr> | 2015-03-18 06:40:02 +0300 |
---|---|---|
committer | Matthieu Napoli <matthieu@mnapoli.fr> | 2015-03-18 06:40:02 +0300 |
commit | 206660ba30564a162a210b94393cd3afeaf9cac5 (patch) | |
tree | 71f97426ed6a336a08d6a1123b5586384010ecd0 /tests/PHPUnit/Unit/DataTable | |
parent | 107fe4d29728b28f7ca6e363ad0508270faa3bd8 (diff) |
#7437 Prevent percentages to go over 100% for browser plugin support
Diffstat (limited to 'tests/PHPUnit/Unit/DataTable')
-rw-r--r-- | tests/PHPUnit/Unit/DataTable/Filter/RangeCheckTest.php | 27 |
1 files changed, 25 insertions, 2 deletions
diff --git a/tests/PHPUnit/Unit/DataTable/Filter/RangeCheckTest.php b/tests/PHPUnit/Unit/DataTable/Filter/RangeCheckTest.php index 0deccd217f..4002424436 100644 --- a/tests/PHPUnit/Unit/DataTable/Filter/RangeCheckTest.php +++ b/tests/PHPUnit/Unit/DataTable/Filter/RangeCheckTest.php @@ -11,13 +11,13 @@ namespace Piwik\Tests\Unit\DataTable\Filter; use Piwik\DataTable\Filter\RangeCheck; use Piwik\DataTable; use Piwik\DataTable\Row; +use Piwik\Plugins\CoreHome\Columns\Metrics\VisitsPercent; /** * @group DataTableTest */ class DataTable_Filter_RangeCheckTest extends \PHPUnit_Framework_TestCase { - public function testRangeCheckNormalDataTable() { $table = new DataTable(); @@ -35,7 +35,6 @@ class DataTable_Filter_RangeCheckTest extends \PHPUnit_Framework_TestCase $this->assertEquals($expectedOrder, $table->getColumn('count')); } - public function testRangeCheckNormalDataTableNonIntegerValues() { $table = new DataTable(); @@ -53,4 +52,28 @@ class DataTable_Filter_RangeCheckTest extends \PHPUnit_Framework_TestCase $this->assertEquals($expectedOrder, $table->getColumn('count')); } + + public function testRangeCheckOnMetadata() + { + $table = new DataTable(); + $table->addRowsFromArray(array( + array( + Row::COLUMNS => array('label' => 'foo'), + Row::METADATA => array('count' => 5), + ), + array( + Row::COLUMNS => array('label' => 'bar'), + Row::METADATA => array('count' => 10), + ), + array( + Row::COLUMNS => array('label' => 'bar'), + Row::METADATA => array('count' => 15), + ), + )); + + $filter = new RangeCheck($table, 'count', 0, 10); + $filter->filter($table); + + $this->assertEquals(array(5, 10, 10), $table->getRowsMetadata('count')); + } } |