Add exception for invalid limit before grouping (#19881)

* add exception for invalid limit before grouping

add exception for invalid limit before grouping

* update int to numeric

update int to numeric

* update getTransitionsForAction limitBeforeGrouping default to int

update getTransitionsForAction limitBeforeGrouping default to int

* Update test name

* remove translation

remove translation

* update all other place from false to 0

update all other place from false to 0

* fix other places using limitBeforeGrouping is false

* update ranking Query from false to 0

update ranking Query from false to 0

* add more tests

add more tests

* update tests

update tests

* remove throw errors

remove throw errors

* remove exception for other places

remove exception for other places

* add throw and tests back

add throw and tests back

* update test case

* update intval to int and false condition

update intval to int and false condition

* revert ranking query from false to 0

revert ranking query from false to 0

Co-authored-by: Ben <ben.burgess@innocraft.com>

1 files changed, 7 insertions, 0 deletions

diff --git a/tests/PHPUnit/Unit/RankingQueryTest.php b/tests/PHPUnit/Unit/RankingQueryTest.php
index f170bacd9f..4320055986 100644
--- a/tests/PHPUnit/Unit/RankingQueryTest.php
+++ b/tests/PHPUnit/Unit/RankingQueryTest.php
@@ -58,6 +58,7 @@ class RankingQueryTest extends \PHPUnit\Framework\TestCase
      */
     public function testExcludeRows()
     {
+
         $query = new RankingQuery(20);
         $query->setOthersLabel('Others');
         $query->addLabelColumn('label');
@@ -89,6 +90,12 @@ class RankingQueryTest extends \PHPUnit\Framework\TestCase
 		";
 
         $this->checkQuery($query, $innerQuery, $expected);
+
+        $query = new RankingQuery('20');
+        $query->setOthersLabel('Others');
+        $query->addLabelColumn('label');
+        $query->setColumnToMarkExcludedRows('exclude_marker');
+        $this->checkQuery($query, $innerQuery, $expected);
     }
 
     /**