diff options
| author | Jordan Maples [MSFT] <49793787+JordanMaples@users.noreply.github.com> | 2019-12-20 01:05:02 +0300 |
|---|---|---|
| committer | Jordan Maples [MSFT] <49793787+JordanMaples@users.noreply.github.com> | 2019-12-20 01:05:02 +0300 |
| commit | 8577033f13a05984824d5d3cd73bafbac1c28080 (patch) | |
| tree | 05e6616b28cd11574e9cb10b5ec9478f62d28ec0 /tests/span_tests.cpp | |
| parent | 3539bd8008ed872f63d3ca71319cf4e5abbfe6c9 (diff) | |
addressing comments
Diffstat (limited to 'tests/span_tests.cpp')
| -rw-r--r-- | tests/span_tests.cpp | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/tests/span_tests.cpp b/tests/span_tests.cpp index 9336812..f619d48 100644 --- a/tests/span_tests.cpp +++ b/tests/span_tests.cpp @@ -26,17 +26,19 @@ #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wundef" #pragma GCC diagnostic ignored "-Wunused-variable" -#endif +#endif // __clang__ || __GNUC__ + #if __clang__ #pragma GCC diagnostic ignored "-Wglobal-constructors" #pragma GCC diagnostic ignored "-Wused-but-marked-unused" #pragma GCC diagnostic ignored "-Wcovered-switch-default" -#endif +#endif // __clang__ + +#include <gtest/gtest.h> #include <gsl/gsl_byte> // for byte #include <gsl/gsl_util> // for narrow_cast, at #include <gsl/span> // for span, span_iterator, operator==, operator!= -#include <gtest/gtest.h> #include <array> // for array #include <iostream> // for ptrdiff_t @@ -58,6 +60,8 @@ using namespace gsl; namespace { +static constexpr char deathstring[] = "Expected Death"; + struct BaseClass { }; @@ -75,7 +79,6 @@ struct AddressOverloaded return {}; } }; -static const char *deathstring("Expected Death"); } // namespace TEST(span_test, constructors) @@ -1642,4 +1645,4 @@ TEST(span_test, from_array_constructor) #if __clang__ || __GNUC__ #pragma GCC diagnostic pop -#endif +#endif // __clang__ || __GNUC__ |