diff options
| author | Alexandru Dima <alexdima@microsoft.com> | 2022-11-09 11:39:28 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-09 11:39:28 +0300 |
| commit | 9e2750335c728625102c6ead448e4a38b4ced945 (patch) | |
| tree | 03451add469df30ce1bc72abc4a59b1116425046 | |
| parent | 8e9fc56766f48e851cbae146c68b021aec5d7033 (diff) | |
Add a fast check to determine if a preferences renderer needs to be created (#165825)
Add a fast check to determine if a preferences renderer needs to be created (#164171)
| -rw-r--r-- | src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts b/src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts index d98c4b94cd7..91a2cd923d1 100644 --- a/src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts +++ b/src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts @@ -35,7 +35,9 @@ export class SettingsEditorContribution extends Disposable { this.currentRenderer = undefined; const model = this.editor.getModel(); - if (model) { + if (model && /\.(json|code-workspace)$/.test(model.uri.path)) { + // Fast check: the preferences renderer can only appear + // in settings files or workspace files const settingsModel = await this.preferencesService.createPreferencesEditorModel(model.uri); if (settingsModel instanceof SettingsEditorModel && this.editor.getModel()) { this.disposables.add(settingsModel); |