diff options
| author | Rob Lourens <roblourens@gmail.com> | 2022-11-13 21:16:37 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-13 21:16:37 +0300 |
| commit | a74a7644f32413fa8f902b349dfdb8bde50ed304 (patch) | |
| tree | e4aa67eca5e4f01b0182ee9536068030a5548057 | |
| parent | 964dc545abd63c5f6f6c42755f1c11c2c912a0b5 (diff) | |
Don't fail to send notebook open perf when reopening the same notebook in an editor (#166235)HEADmain
Fix #135834
| -rw-r--r-- | src/vs/workbench/contrib/notebook/browser/notebookEditor.ts | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts b/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts index 75680fbdebe..0cdecde7cf3 100644 --- a/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts +++ b/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts @@ -256,7 +256,7 @@ export class NotebookEditor extends EditorPane implements INotebookEditorPane { extensionActivated: number; inputLoaded: number; webviewCommLoaded: number; - customMarkdownLoaded: number; + customMarkdownLoaded: number | undefined; editorLoaded: number; }; @@ -272,7 +272,6 @@ export class NotebookEditor extends EditorPane implements INotebookEditorPane { startTime !== undefined && extensionActivated !== undefined && inputLoaded !== undefined - && customMarkdownLoaded !== undefined && editorLoaded !== undefined ) { this.telemetryService.publicLog2<WorkbenchNotebookOpenEvent, WorkbenchNotebookOpenClassification>('notebook/editorOpenPerf', { @@ -282,11 +281,11 @@ export class NotebookEditor extends EditorPane implements INotebookEditorPane { extensionActivated: extensionActivated - startTime, inputLoaded: inputLoaded - startTime, webviewCommLoaded: inputLoaded - startTime, - customMarkdownLoaded: customMarkdownLoaded - startTime, + customMarkdownLoaded: typeof customMarkdownLoaded === 'number' ? customMarkdownLoaded - startTime : undefined, editorLoaded: editorLoaded - startTime }); } else { - console.warn(`notebook file open perf marks are broken: startTime ${startTime}, extensionActiviated ${extensionActivated}, inputLoaded ${inputLoaded}, customMarkdownLoaded ${customMarkdownLoaded}, editorLoaded ${editorLoaded}`); + console.warn(`notebook file open perf marks are broken: startTime ${startTime}, extensionActivated ${extensionActivated}, inputLoaded ${inputLoaded}, customMarkdownLoaded ${customMarkdownLoaded}, editorLoaded ${editorLoaded}`); } } } catch (e) { |