diff options
| author | Benjamin Pasero <benjamin.pasero@microsoft.com> | 2022-02-15 18:27:08 +0300 |
|---|---|---|
| committer | Benjamin Pasero <benjamin.pasero@microsoft.com> | 2022-02-15 18:27:08 +0300 |
| commit | b344f434980621de2ddf35d5788c16a8399bc765 (patch) | |
| tree | ab8ea7267232b1abbcbe82ee34c3e702031f777c /scripts | |
| parent | a53624cc511c4d2f6e2f6844899be8496925c758 (diff) | |
Revert "linux: disable crash reporting in CI (#142572)"
This reverts commit 7dbd7367dc96690ae1cae12f9d74191b3f21b6fe.
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/test-integration.sh | 3 | ||||
| -rwxr-xr-x | scripts/test-remote-integration.sh | 3 | ||||
| -rwxr-xr-x | scripts/test.sh | 3 |
3 files changed, 3 insertions, 6 deletions
diff --git a/scripts/test-integration.sh b/scripts/test-integration.sh index 418b6bb8a6c..2fb82e34740 100755 --- a/scripts/test-integration.sh +++ b/scripts/test-integration.sh @@ -8,8 +8,7 @@ else ROOT=$(dirname $(dirname $(readlink -f $0))) # --disable-dev-shm-usage --use-gl=swiftshader: when run on docker containers where size of /dev/shm # partition < 64MB which causes OOM failure for chromium compositor that uses the partition for shared memory - # --disable-crash-reporter: TODO@electron this needs Electron 17 to work (https://github.com/microsoft/vscode/issues/142572) - LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader --disable-crash-reporter" + LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader" fi VSCODEUSERDATADIR=`mktemp -d 2>/dev/null` diff --git a/scripts/test-remote-integration.sh b/scripts/test-remote-integration.sh index d1029aaa277..39c36592e24 100755 --- a/scripts/test-remote-integration.sh +++ b/scripts/test-remote-integration.sh @@ -8,8 +8,7 @@ else ROOT=$(dirname $(dirname $(readlink -f $0))) # --disable-dev-shm-usage --use-gl=swiftshader: when run on docker containers where size of /dev/shm # partition < 64MB which causes OOM failure for chromium compositor that uses the partition for shared memory - # --disable-crash-reporter: TODO@electron this needs Electron 17 to work (https://github.com/microsoft/vscode/issues/142572) - LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader --disable-crash-reporter" + LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader" fi VSCODEUSERDATADIR=`mktemp -d 2>/dev/null` diff --git a/scripts/test.sh b/scripts/test.sh index 4c3021d474d..14a72e09cc3 100755 --- a/scripts/test.sh +++ b/scripts/test.sh @@ -8,8 +8,7 @@ else ROOT=$(dirname $(dirname $(readlink -f $0))) # --disable-dev-shm-usage --use-gl=swiftshader: when run on docker containers where size of /dev/shm # partition < 64MB which causes OOM failure for chromium compositor that uses the partition for shared memory - # --disableCrashReporter: TODO@electron this needs Electron 17 to work (https://github.com/microsoft/vscode/issues/142572) - LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader --disableCrashReporter" + LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader" fi cd $ROOT |