diff options
author | Adam Langley <agl@google.com> | 2015-01-31 04:08:37 +0300 |
---|---|---|
committer | Adam Langley <agl@google.com> | 2015-02-02 22:14:15 +0300 |
commit | 2b2d66d4094e5c25789ce68310d86192c377c63b (patch) | |
tree | 0037574fca9fad9755016ccc0f8e4ddb0f978a59 /crypto/modes | |
parent | efed2210e8e0c6b3db6c63e354f0c9b67673c712 (diff) |
Remove string.h from base.h.
Including string.h in base.h causes any file that includes a BoringSSL
header to include string.h. Generally this wouldn't be a problem,
although string.h might slow down the compile if it wasn't otherwise
needed. However, it also causes problems for ipsec-tools in Android
because OpenSSL didn't have this behaviour.
This change removes string.h from base.h and, instead, adds it to each
.c file that requires it.
Change-Id: I5968e50b0e230fd3adf9b72dd2836e6f52d6fb37
Reviewed-on: https://boringssl-review.googlesource.com/3200
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>
Diffstat (limited to 'crypto/modes')
-rw-r--r-- | crypto/modes/cbc.c | 1 | ||||
-rw-r--r-- | crypto/modes/cfb.c | 1 | ||||
-rw-r--r-- | crypto/modes/ctr.c | 1 | ||||
-rw-r--r-- | crypto/modes/gcm.c | 1 | ||||
-rw-r--r-- | crypto/modes/gcm_test.c | 1 |
5 files changed, 5 insertions, 0 deletions
diff --git a/crypto/modes/cbc.c b/crypto/modes/cbc.c index 83d58f0f..a2ad26ca 100644 --- a/crypto/modes/cbc.c +++ b/crypto/modes/cbc.c @@ -48,6 +48,7 @@ #include <openssl/modes.h> #include <assert.h> +#include <string.h> #include "internal.h" diff --git a/crypto/modes/cfb.c b/crypto/modes/cfb.c index df7cb771..738a4380 100644 --- a/crypto/modes/cfb.c +++ b/crypto/modes/cfb.c @@ -49,6 +49,7 @@ #include <openssl/modes.h> #include <assert.h> +#include <string.h> #include "internal.h" diff --git a/crypto/modes/ctr.c b/crypto/modes/ctr.c index 3f8f91fb..61832ba4 100644 --- a/crypto/modes/ctr.c +++ b/crypto/modes/ctr.c @@ -48,6 +48,7 @@ #include <openssl/modes.h> #include <assert.h> +#include <string.h> #include "internal.h" diff --git a/crypto/modes/gcm.c b/crypto/modes/gcm.c index f09637bf..eeaeeffc 100644 --- a/crypto/modes/gcm.c +++ b/crypto/modes/gcm.c @@ -49,6 +49,7 @@ #include <openssl/modes.h> #include <assert.h> +#include <string.h> #include <openssl/mem.h> #include <openssl/cpu.h> diff --git a/crypto/modes/gcm_test.c b/crypto/modes/gcm_test.c index 5308976e..29f9d95f 100644 --- a/crypto/modes/gcm_test.c +++ b/crypto/modes/gcm_test.c @@ -47,6 +47,7 @@ * ==================================================================== */ #include <stdio.h> +#include <string.h> #include <openssl/aes.h> #include <openssl/crypto.h> |