diff options
| author | David Benjamin <davidben@chromium.org> | 2014-12-16 15:48:10 +0300 |
|---|---|---|
| committer | Adam Langley <agl@google.com> | 2014-12-16 22:15:59 +0300 |
| commit | a6d81018f8fd5647d88a49923633f29dd77c2365 (patch) | |
| tree | a2182160a477558c1919642629a684046938c42b /crypto/pem | |
| parent | 263eac02f5c27ad91c1514c93246b84980f73c97 (diff) | |
Consistently use RAND_bytes and check for failure.
RAND_pseudo_bytes just calls RAND_bytes now and only returns 0 or 1. Switch all
callers within the library call the new one and use the simpler failure check.
This fixes a few error checks that no longer work (< 0) and some missing ones.
Change-Id: Id51c79deec80075949f73fa1fbd7b76aac5570c6
Reviewed-on: https://boringssl-review.googlesource.com/2621
Reviewed-by: Adam Langley <agl@google.com>
Diffstat (limited to 'crypto/pem')
| -rw-r--r-- | crypto/pem/pem_lib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/pem/pem_lib.c b/crypto/pem/pem_lib.c index e16256eb..08760081 100644 --- a/crypto/pem/pem_lib.c +++ b/crypto/pem/pem_lib.c @@ -340,7 +340,7 @@ int PEM_ASN1_write_bio(i2d_of_void *i2d, const char *name, BIO *bp, kstr=(unsigned char *)buf; } assert(iv_len <= (int)sizeof(iv)); - if (RAND_pseudo_bytes(iv,iv_len) < 0) /* Generate a salt */ + if (!RAND_bytes(iv, iv_len)) /* Generate a salt */ goto err; /* The 'iv' is used as the iv and as a salt. It is * NOT taken from the BytesToKey function */ |