diff options
| author | David Benjamin <davidben@chromium.org> | 2015-12-05 05:01:24 +0300 |
|---|---|---|
| committer | Adam Langley <agl@google.com> | 2015-12-15 23:07:37 +0300 |
| commit | 53e5c2c225122be728806c3b020859b4c9075a76 (patch) | |
| tree | cf3a34966bcf8a27ad84dae77cd7261e9856de27 /ssl/ssl_cert.c | |
| parent | 756ad173371b9862a78bdd69549e739fedd5636b (diff) | |
Remove SSL_(CTX_)?set_ecdh_callback.
It has no callers. I prepped for its removal earlier with
https://android.googlesource.com/platform/external/conscrypt/+/c05697c2c50fe1331f08c6f32d0bc9636eecdc2d
and then completely forgot.
Thanks to upstream's 6f78b9e824c053d062188578635c575017b587c5 for
the reminder. Quoth them:
> This only gets used to set a specific curve without actually checking
> that the peer supports it or not and can therefor result in handshake
> failures that can be avoided by selecting a different cipher.
It's also a very confusing API since it does NOT pass ownership of the
EC_KEY to the caller.
Change-Id: I6a00643b3a2d6746e9e0e228b47c2bc9694b0084
Reviewed-on: https://boringssl-review.googlesource.com/6621
Reviewed-by: Adam Langley <agl@google.com>
Diffstat (limited to 'ssl/ssl_cert.c')
| -rw-r--r-- | ssl/ssl_cert.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ssl/ssl_cert.c b/ssl/ssl_cert.c index 4094b27a..8788152d 100644 --- a/ssl/ssl_cert.c +++ b/ssl/ssl_cert.c @@ -186,7 +186,6 @@ CERT *ssl_cert_dup(CERT *cert) { ret->dh_tmp_cb = cert->dh_tmp_cb; ret->ecdh_nid = cert->ecdh_nid; - ret->ecdh_tmp_cb = cert->ecdh_tmp_cb; if (cert->x509 != NULL) { ret->x509 = X509_up_ref(cert->x509); |