Fix locally scoped constant array (#644)

* add failing test for LocallyScopedConstantArray

* add LocallyScopedConstantArray target assembly

* ElementType.Array should be treated the same as object in ReadLocalConstant

* assert constant is null

* Style fixes

Co-authored-by: Jb Evain <jb@evain.net>

3 files changed, 14 insertions, 0 deletions

diff --git a/Test/Mono.Cecil.Tests/ImageReadTests.cs b/Test/Mono.Cecil.Tests/ImageReadTests.cs
index fa5562e..de7a2cc 100644
--- a/Test/Mono.Cecil.Tests/ImageReadTests.cs
+++ b/Test/Mono.Cecil.Tests/ImageReadTests.cs
@@ -208,6 +208,20 @@ namespace Mono.Cecil.Tests {
 		}
 
 		[Test]
+		public void LocallyScopedConstantArray ()
+		{
+			TestModule ("LocallyScopedConstantArray.dll", module => {
+				Assert.IsTrue (module.HasDebugHeader);
+				var method = module.Types
+					.Single (x => x.Name == "TestClass")
+					.Methods
+					.Single (x => x.Name == "TestMethod");
+				var debugInformation = method.DebugInformation;
+				Assert.IsNull (debugInformation.Scope.Constants.Single ().Value);
+			}, symbolReaderProvider: typeof (PortablePdbReaderProvider), symbolWriterProvider: typeof (PortablePdbWriterProvider));
+		}
+
+		[Test]
 		public void ExternalPdbDeterministicAssembly ()
 		{
 			TestModule ("ExternalPdbDeterministic.dll", module => {
diff --git a/Test/Resources/assemblies/LocallyScopedConstantArray.dll b/Test/Resources/assemblies/LocallyScopedConstantArray.dll
new file mode 100644
index 0000000..ae5eaf4
--- /dev/null
+++ b/Test/Resources/assemblies/LocallyScopedConstantArray.dll
diff --git a/Test/Resources/assemblies/LocallyScopedConstantArray.pdb b/Test/Resources/assemblies/LocallyScopedConstantArray.pdb
new file mode 100644
index 0000000..eea50b9
--- /dev/null
+++ b/Test/Resources/assemblies/LocallyScopedConstantArray.pdb