diff options
author | Alexander Köplinger <alex.koeplinger@outlook.com> | 2019-09-27 21:30:02 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-09-27 21:30:02 +0300 |
commit | 10a41e9f9828b3e299215406eadfde2ee4c9b29f (patch) | |
tree | 9087536bd578790ce6cb454a08d4419b01ce7ef9 | |
parent | 0da6ecef079a34c9788297ca24426f9665d9963c (diff) |
Fix ReadOnlySequence.cs build with mcs (#354)
Remove the nullability annotations for now.
-rw-r--r-- | src/System.Memory/src/System/Buffers/ReadOnlySequence.cs | 26 | ||||
-rw-r--r-- | src/System.Memory/src/System/Buffers/ReadOnlySequence_helpers.cs | 18 |
2 files changed, 22 insertions, 22 deletions
diff --git a/src/System.Memory/src/System/Buffers/ReadOnlySequence.cs b/src/System.Memory/src/System/Buffers/ReadOnlySequence.cs index 34a2997cd3..1f53b84893 100644 --- a/src/System.Memory/src/System/Buffers/ReadOnlySequence.cs +++ b/src/System.Memory/src/System/Buffers/ReadOnlySequence.cs @@ -121,7 +121,7 @@ namespace System.Buffers _startObject = array; _endObject = array; _startInteger = ReadOnlySequence.ArrayToSequenceStart(0); - _endInteger = ReadOnlySequence.ArrayToSequenceEnd(array!.Length); // TODO-NULLABLE: Remove ! when [DoesNotReturn] respected + _endInteger = ReadOnlySequence.ArrayToSequenceEnd(array.Length); } /// <summary> @@ -218,22 +218,22 @@ namespace System.Buffers startIndex += (int)start; begin = new SequencePosition(startObject, startIndex); - end = GetEndPosition(startSegment, startObject, startIndex, endObject!, endIndex, length); + end = GetEndPosition(startSegment, startObject, startIndex, endObject, endIndex, length); } else { if (currentLength < 0) ThrowHelper.ThrowArgumentOutOfRangeException_PositionOutOfRange(); - begin = SeekMultiSegment(startSegment.Next!, endObject!, endIndex, start - currentLength, ExceptionArgument.start); + begin = SeekMultiSegment(startSegment.Next, endObject, endIndex, start - currentLength, ExceptionArgument.start); int beginIndex = GetIndex(begin); - object beginObject = begin.GetObject()!; + object beginObject = begin.GetObject(); if (beginObject != endObject) { Debug.Assert(beginObject != null); - end = GetEndPosition((ReadOnlySequenceSegment<T>)beginObject, beginObject, beginIndex, endObject!, endIndex, length); + end = GetEndPosition((ReadOnlySequenceSegment<T>)beginObject, beginObject, beginIndex, endObject, endIndex, length); } else { @@ -302,16 +302,16 @@ namespace System.Buffers } // Multi-Segment Sequence - var startSegment = (ReadOnlySequenceSegment<T>)startObject!; + var startSegment = (ReadOnlySequenceSegment<T>)startObject; ulong startRange = (ulong)(startSegment.RunningIndex + startIndex); - ulong sliceRange = (ulong)(((ReadOnlySequenceSegment<T>)sliceEndObject!).RunningIndex + sliceEndIndex); + ulong sliceRange = (ulong)(((ReadOnlySequenceSegment<T>)sliceEndObject).RunningIndex + sliceEndIndex); // This optimization works because we know sliceEndIndex, startIndex, and endIndex are all >= 0 Debug.Assert(sliceEndIndex >= 0 && startIndex >= 0 && endIndex >= 0); if (!InRange( sliceRange, startRange, - (ulong)(((ReadOnlySequenceSegment<T>)endObject!).RunningIndex + endIndex))) + (ulong)(((ReadOnlySequenceSegment<T>)endObject).RunningIndex + endIndex))) { ThrowHelper.ThrowArgumentOutOfRangeException_PositionOutOfRange(); } @@ -330,7 +330,7 @@ namespace System.Buffers ThrowHelper.ThrowArgumentOutOfRangeException_PositionOutOfRange(); // End of segment. Move to start of next. - SequencePosition begin = SeekMultiSegment(startSegment.Next!, sliceEndObject, (int)sliceEndIndex, start - currentLength, ExceptionArgument.start); + SequencePosition begin = SeekMultiSegment(startSegment.Next, sliceEndObject, (int)sliceEndIndex, start - currentLength, ExceptionArgument.start); return SliceImpl(begin, end); } @@ -383,10 +383,10 @@ namespace System.Buffers } // Multi-Segment Sequence - var sliceStartSegment = (ReadOnlySequenceSegment<T>)sliceStartObject!; + var sliceStartSegment = (ReadOnlySequenceSegment<T>)sliceStartObject; ulong sliceRange = (ulong)((sliceStartSegment.RunningIndex + sliceStartIndex)); - ulong startRange = (ulong)(((ReadOnlySequenceSegment<T>)startObject!).RunningIndex + startIndex); - ulong endRange = (ulong)(((ReadOnlySequenceSegment<T>)endObject!).RunningIndex + endIndex); + ulong startRange = (ulong)(((ReadOnlySequenceSegment<T>)startObject).RunningIndex + startIndex); + ulong endRange = (ulong)(((ReadOnlySequenceSegment<T>)endObject).RunningIndex + endIndex); // This optimization works because we know sliceStartIndex, startIndex, and endIndex are all >= 0 Debug.Assert(sliceStartIndex >= 0 && startIndex >= 0 && endIndex >= 0); @@ -413,7 +413,7 @@ namespace System.Buffers ThrowHelper.ThrowArgumentOutOfRangeException_PositionOutOfRange(); // End of segment. Move to start of next. - SequencePosition end = SeekMultiSegment(sliceStartSegment.Next!, endObject, (int)endIndex, length - currentLength, ExceptionArgument.length); + SequencePosition end = SeekMultiSegment(sliceStartSegment.Next, endObject, (int)endIndex, length - currentLength, ExceptionArgument.length); return SliceImpl(start, end); } diff --git a/src/System.Memory/src/System/Buffers/ReadOnlySequence_helpers.cs b/src/System.Memory/src/System/Buffers/ReadOnlySequence_helpers.cs index 21b7826ee2..0b6965e430 100644 --- a/src/System.Memory/src/System/Buffers/ReadOnlySequence_helpers.cs +++ b/src/System.Memory/src/System/Buffers/ReadOnlySequence_helpers.cs @@ -255,7 +255,7 @@ namespace System.Buffers ThrowHelper.ThrowArgumentOutOfRangeException_PositionOutOfRange(); // End of segment. Move to start of next. - return SeekMultiSegment(startSegment.Next!, endObject!, endIndex, offset - currentLength, exceptionArgument); + return SeekMultiSegment(startSegment.Next, endObject, endIndex, offset - currentLength, exceptionArgument); } Debug.Assert(startObject == endObject); @@ -291,7 +291,7 @@ namespace System.Buffers ThrowHelper.ThrowArgumentOutOfRangeException_PositionOutOfRange(); // End of segment. Move to start of next. - return SeekMultiSegment(startSegment.Next!, endObject!, endIndex, offset - currentLength, ExceptionArgument.offset); + return SeekMultiSegment(startSegment.Next, endObject, endIndex, offset - currentLength, ExceptionArgument.offset); } Debug.Assert(startObject == endObject); @@ -353,18 +353,18 @@ namespace System.Buffers { // Multi-Segment Sequence // Storing this in a local since it is used twice within InRange() - ulong startRange = (ulong)(((ReadOnlySequenceSegment<T>)startObject!).RunningIndex + startIndex); + ulong startRange = (ulong)(((ReadOnlySequenceSegment<T>)startObject).RunningIndex + startIndex); long runningIndex = 0; if (positionIsNotNull) { Debug.Assert(position.GetObject() != null); - runningIndex = ((ReadOnlySequenceSegment<T>)position.GetObject()!).RunningIndex; + runningIndex = ((ReadOnlySequenceSegment<T>)position.GetObject()).RunningIndex; } if (!InRange( (ulong)(runningIndex + sliceStartIndex), startRange, - (ulong)(((ReadOnlySequenceSegment<T>)endObject!).RunningIndex + endIndex))) + (ulong)(((ReadOnlySequenceSegment<T>)endObject).RunningIndex + endIndex))) { ThrowHelper.ThrowArgumentOutOfRangeException_PositionOutOfRange(); } @@ -413,8 +413,8 @@ namespace System.Buffers if (sliceStartRange > sliceEndRange) ThrowHelper.ThrowArgumentOutOfRangeException_PositionOutOfRange(); - if (sliceStartRange < (ulong)(((ReadOnlySequenceSegment<T>)startObject!).RunningIndex + startIndex) - || sliceEndRange > (ulong)(((ReadOnlySequenceSegment<T>)endObject!).RunningIndex + endIndex)) + if (sliceStartRange < (ulong)(((ReadOnlySequenceSegment<T>)startObject).RunningIndex + startIndex) + || sliceEndRange > (ulong)(((ReadOnlySequenceSegment<T>)endObject).RunningIndex + endIndex)) { ThrowHelper.ThrowArgumentOutOfRangeException_PositionOutOfRange(); } @@ -507,8 +507,8 @@ namespace System.Buffers if (startObject != endObject) { - var startSegment = (ReadOnlySequenceSegment<T>)startObject!; - var endSegment = (ReadOnlySequenceSegment<T>)endObject!; + var startSegment = (ReadOnlySequenceSegment<T>)startObject; + var endSegment = (ReadOnlySequenceSegment<T>)endObject; // (End offset) - (start offset) return (endSegment.RunningIndex + endIndex) - (startSegment.RunningIndex + startIndex); } |