diff options
| author | Karel Zikmund <karelz@microsoft.com> | 2017-06-02 16:03:06 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-06-02 16:03:06 +0300 |
| commit | bf3fe3b207d4eb35d4260075c6efb214c55e8929 (patch) | |
| tree | 0d7380d24126192aa10314a245c2639c45771099 /Documentation | |
| parent | 883f3138fa75e35c4cccc69f132b967bc78ab316 (diff) | |
Update issue-guide.md
Diffstat (limited to 'Documentation')
| -rw-r--r-- | Documentation/project-docs/issue-guide.md | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/Documentation/project-docs/issue-guide.md b/Documentation/project-docs/issue-guide.md index cae602ead1..e8390c2fe9 100644 --- a/Documentation/project-docs/issue-guide.md +++ b/Documentation/project-docs/issue-guide.md @@ -113,7 +113,7 @@ Feel free to use other labels if it helps your triage efforts (e.g. **needs more #### Motivation for triage rules -1. Each issue has exactly one **area-*** label +1. Each issue has exactly one **area-\*** label * Motivation: Issues with multiple areas have loose responbility (everyone blames the other side) and issues are double counted in reports. 1. Issue has no **Assignee**, unless someone is working on the issue at the moment * Motivation: Observation is that contributors are less likely to grab assigned issues, no matter what the repo rules say. @@ -125,3 +125,13 @@ Feel free to use other labels if it helps your triage efforts (e.g. **needs more * Don't be afraid to be wrong when deciding 'bug' vs. 'test bug' (flip a coin if you must). The most useful values for tracking are 'api-*' vs. 'enhancement', 'question', and 'documentation'. 1. Don't be afraid to say no, or close issues - just explain why and be polite 1. Don't be afraid to be wrong - just be flexible when new information appears + +#### PR rules + +1. Each PR has exactly one **area-\*** label + * Movitation: Area owners will get email notification about new issue in their area. +1. PR has **Assignee** set to author of the PR, if it is non-CoreFX engineer, then area owners are co-assignees + * Motivation: Area owners are responsible to do code reviews for PRs from external contributors. CoreFX engineers know how to get code reviews from others. +1. Any other labels on PRs are superfluous and not needed (exceptions: **blocked**, **NO MERGE**) + * Motivation: All the important info (*issue type* label, api approval label, OS label, etc.) is already captured on the associated issue. +1. Push PRs forward, don't let them go stale (response every 5+ days, ideally no PRs older than 2 weeks) |