diff options
| author | Santiago Fernandez Madero <safern@microsoft.com> | 2017-10-11 03:00:49 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-10-11 03:00:49 +0300 |
| commit | c2fb45936857c64fda2add64c5a950bd5bee4a9e (patch) | |
| tree | 61553228702db6ca48b0f0796a25996d3bbdd2ae /external | |
| parent | 80b1685be8043b3a36a83a0faee1ab34178552d4 (diff) | |
Make coreclr symbols download incremental (#24556)
Diffstat (limited to 'external')
| -rw-r--r-- | external/runtime/runtime.depproj | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/external/runtime/runtime.depproj b/external/runtime/runtime.depproj index 5483f9951d..7a3c76cf90 100644 --- a/external/runtime/runtime.depproj +++ b/external/runtime/runtime.depproj @@ -81,11 +81,16 @@ BeforeTargets="DownloadAndUnzipSymbolPackage"> <ItemGroup> - <SymbolPackagesToDownload Include="@(ReferenceCopyLocalPaths->'%(NuGetPackageId)')" Condition="$([System.String]::Copy('%(Identity)').EndsWith('System.Private.CoreLib.dll'))"> + <_CoreCLRSymbolPackagesToDownload Include="@(ReferenceCopyLocalPaths->'%(NuGetPackageId)')" Condition="$([System.String]::Copy('%(Identity)').EndsWith('System.Private.CoreLib.dll'))"> <Url>https://dotnet.myget.org/F/dotnet-core/symbols/%(NuGetPackageId)/%(NuGetPackageVersion)/</Url> <DestinationFile>%(NuGetPackageId).%(NuGetPackageVersion).symbols.nupkg.zip</DestinationFile> <UnzipDestinationDir>$(SymbolPackagesDir)/%(NuGetPackageId).%(NuGetPackageVersion)</UnzipDestinationDir> - </SymbolPackagesToDownload> + </_CoreCLRSymbolPackagesToDownload> + </ItemGroup> + + <!-- Calculate the packages to download incrementally if we haven't downloaded them --> + <ItemGroup> + <SymbolPackagesToDownload Include="@(_CoreCLRSymbolPackagesToDownload)" Condition="!Exists('%(UnzipDestinationDir)')" /> </ItemGroup> </Target> @@ -94,12 +99,12 @@ DependsOnTargets="CalculateCoreCLRSymbolPackageProperties;DownloadAndUnzipSymbolPackage" Condition="'$(CoreCLROverridePath)' == '' AND '$(DownloadCoreCLRSymbols)' != 'false'"> - <Warning Text="Failed to download CoreCLR symbols" Condition="@(SymbolPackagesDownloaded) == ''" /> + <Warning Text="Failed to download CoreCLR symbols" Condition="'@(SymbolPackagesDownloaded)' == '' AND '@(SymbolPackagesToDownload)' != ''" /> <ItemGroup> - <_CoreCLRSymbolFiles Condition="@(SymbolPackagesDownloaded) != ''" Include="%(SymbolPackagesDownloaded.UnzipDestinationDir)/runtimes/$(NugetRuntimeIdentifier)/native/*.pdb" /> - <_CoreCLRSymbolFiles Condition="@(SymbolPackagesDownloaded) != ''" Include="%(SymbolPackagesDownloaded.UnzipDestinationDir)/runtimes/$(NugetRuntimeIdentifier)/native/*.dbg" /> - <ReferenceCopyLocalPaths Condition="@(SymbolPackagesDownloaded) != ''" Include="@(_CoreCLRSymbolFiles)"/> + <_CoreCLRSymbolFiles Include="%(_CoreCLRSymbolPackagesToDownload.UnzipDestinationDir)/runtimes/$(NugetRuntimeIdentifier)/native/*.pdb" /> + <_CoreCLRSymbolFiles Include="%(_CoreCLRSymbolPackagesToDownload.UnzipDestinationDir)/runtimes/$(NugetRuntimeIdentifier)/native/*.dbg" /> + <ReferenceCopyLocalPaths Include="@(_CoreCLRSymbolFiles)"/> </ItemGroup> </Target> |