diff options
author | dotnet-bot <dotnet-bot@microsoft.com> | 2015-01-30 23:53:07 +0300 |
---|---|---|
committer | dotnet-bot <dotnet-bot@microsoft.com> | 2015-01-30 23:53:07 +0300 |
commit | 3efb06d23228ab5709bc312db360cf1eccdda377 (patch) | |
tree | 247b3a8aac117d0d38e9a565502f9df4addeae0f /src/System.Collections.NonGeneric/tests/ArrayList | |
parent | 67a32d329f13b479753eb5e2191584045b6324e2 (diff) |
Modify tests to use Task.Run per Steve's feedbacks
Diffstat (limited to 'src/System.Collections.NonGeneric/tests/ArrayList')
4 files changed, 11 insertions, 13 deletions
diff --git a/src/System.Collections.NonGeneric/tests/ArrayList/GetEnumeratorTests.cs b/src/System.Collections.NonGeneric/tests/ArrayList/GetEnumeratorTests.cs index d07321f5ab..0d00c52a6a 100644 --- a/src/System.Collections.NonGeneric/tests/ArrayList/GetEnumeratorTests.cs +++ b/src/System.Collections.NonGeneric/tests/ArrayList/GetEnumeratorTests.cs @@ -216,7 +216,6 @@ namespace System.Collections.ArrayListTests } Assert.False(enu.MoveNext()); - enu.Reset(); } diff --git a/src/System.Collections.NonGeneric/tests/ArrayList/PropertyIsSynchronizedTests.cs b/src/System.Collections.NonGeneric/tests/ArrayList/PropertyIsSynchronizedTests.cs index 331e14ee7f..5a3cf9740e 100644 --- a/src/System.Collections.NonGeneric/tests/ArrayList/PropertyIsSynchronizedTests.cs +++ b/src/System.Collections.NonGeneric/tests/ArrayList/PropertyIsSynchronizedTests.cs @@ -34,10 +34,10 @@ namespace System.Collections.ArrayListTests workers = new Task[iNumberOfWorkers]; ts1 = new Action(AddElements); - // LongRunning will have problem when run in xUnit + for (int i = 0; i < workers.Length; i++) { - workers[i] = Task.Factory.StartNew(ts1, TaskCreationOptions.LongRunning); + workers[i] = Task.Run(ts1); } Task.WaitAll(workers); @@ -64,7 +64,7 @@ namespace System.Collections.ArrayListTests ts1 = new Action(RemoveElements); for (int i = 0; i < workers.Length; i++) { - workers[i] = Task.Factory.StartNew(ts1, TaskCreationOptions.LongRunning); + workers[i] = Task.Run(ts1); } Task.WaitAll(workers); diff --git a/src/System.Collections.NonGeneric/tests/ArrayList/PropertySyncRootTests.cs b/src/System.Collections.NonGeneric/tests/ArrayList/PropertySyncRootTests.cs index 3e14801079..8e24b18503 100644 --- a/src/System.Collections.NonGeneric/tests/ArrayList/PropertySyncRootTests.cs +++ b/src/System.Collections.NonGeneric/tests/ArrayList/PropertySyncRootTests.cs @@ -27,7 +27,7 @@ namespace System.Collections.ArrayListTests Task[] workers; Action ts1; Action ts2; - int iNumberOfWorkers = 100; + int iNumberOfWorkers = 10; //[] Vanila test case - testing SyncRoot is not as simple as its implementation looks like. This is the working //scenrio we have in mind. @@ -67,9 +67,8 @@ namespace System.Collections.ArrayListTests ts2 = new Action(ReverseElements); for (int iThreads = 0; iThreads < iNumberOfWorkers; iThreads += 2) { - - workers[iThreads] = Task.Factory.StartNew(ts1, TaskCreationOptions.LongRunning); - workers[iThreads + 1] = Task.Factory.StartNew(ts2, TaskCreationOptions.LongRunning); + workers[iThreads] = Task.Run(ts1); + workers[iThreads + 1] = Task.Run(ts2); } Task.WaitAll(workers); diff --git a/src/System.Collections.NonGeneric/tests/ArrayList/SynchronizedTests.cs b/src/System.Collections.NonGeneric/tests/ArrayList/SynchronizedTests.cs index df30e9e410..89cf01f256 100644 --- a/src/System.Collections.NonGeneric/tests/ArrayList/SynchronizedTests.cs +++ b/src/System.Collections.NonGeneric/tests/ArrayList/SynchronizedTests.cs @@ -51,10 +51,10 @@ namespace System.Collections.ArrayListTests workers = new Task[iNumberOfWorkers]; ts1 = new Action(AddElements); - // LongRunning will have problem when running under xUint + // for (int i = 0; i < workers.Length; i++) { - workers[i] = Task.Factory.StartNew(ts1, TaskCreationOptions.LongRunning); + workers[i] = Task.Run(ts1); } Task.WaitAll(workers); @@ -77,10 +77,10 @@ namespace System.Collections.ArrayListTests workers = new Task[iNumberOfWorkers]; ts1 = new Action(RemoveElements); - // LongRunning will have problem with xUnit run + // for (int i = 0; i < workers.Length; i++) { - workers[i] = Task.Factory.StartNew(ts1, TaskCreationOptions.LongRunning); + workers[i] = Task.Run(ts1); } Task.WaitAll(workers); @@ -123,7 +123,7 @@ namespace System.Collections.ArrayListTests { var name = "ThreadID " + i.ToString(); Action delegStartMethod = () => AddElems(name); - workers[i] = Task.Factory.StartNew(delegStartMethod, TaskCreationOptions.LongRunning); + workers[i] = Task.Run(delegStartMethod); } Task.WaitAll(workers); |