Reduce ifs / branches in StartConfiguring

Shaves a small but measurable amount off each StartConfiguring call.

1 files changed, 13 insertions, 3 deletions

diff --git a/src/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.cs b/src/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.cs
index a54ca035a0..45e1d0f8c3 100644
--- a/src/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.cs
+++ b/src/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.cs
@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Threading;
 
 namespace System.Net.Sockets
@@ -418,14 +419,23 @@ namespace System.Net.Sockets
         private void StartConfiguring()
         {
             int status = Interlocked.CompareExchange(ref _operating, Configuring, Free);
-            if (status == InProgress || status == Configuring)
+            if (status != Free)
             {
-                throw new InvalidOperationException(SR.net_socketopinprogress);
+                ThrowForNonFreeStatus(status);
             }
-            else if (status == Disposed)
+        }
+
+        private void ThrowForNonFreeStatus(int status)
+        {
+            Debug.Assert(status == InProgress || status == Configuring || status == Disposed, $"Unexpected status: {status}");
+            if (status == Disposed)
             {
                 throw new ObjectDisposedException(GetType().FullName);
             }
+            else
+            {
+                throw new InvalidOperationException(SR.net_socketopinprogress);
+            }
         }
 
         // Prepares for a native async socket call.