diff options
| author | Eric StJohn <ericstj@microsoft.com> | 2018-04-20 22:58:42 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-04-20 22:58:42 +0300 |
| commit | 850a896ccd92c9bf52d15281c40a5a0e22ec3e33 (patch) | |
| tree | 196b052c37bb5f5ce3a25fe83dc43450e8c532bc /src/System.Numerics.Vectors/ref/System.Numerics.Vectors.csproj | |
| parent | f12dd1546220dd3aac70890f32fad629e1c162e0 (diff) | |
Lock Vectors reference assembly to 4.1.3.0 and don't OOB it on netcoreapp2.0 (#29182)
System.Numerics.Vectors was made inbox in netcoreapp2.0, we were still allowing distribution
in the package, however the package was applying the netstandard2.0 implementation to
netcoreapp2.0.
Now that we've disabled oobing the netcoreapp2.1 build (since many types were moved into
corelib) it no longer makes sense for us to mantain the ability to oob the netcoreapp2.0 build.
Doing so not only degrades the inbox version (by not using the framework's MathF
implementation) but also creates type-unfication issues on rollforward: app targets 2.0
carries OOB copy of Vectors with higher version than 2.1, rolls forward to 2.1 and host will
use the OOB copy, no longer unifying to the types in corelib.
Diffstat (limited to 'src/System.Numerics.Vectors/ref/System.Numerics.Vectors.csproj')
| -rw-r--r-- | src/System.Numerics.Vectors/ref/System.Numerics.Vectors.csproj | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/src/System.Numerics.Vectors/ref/System.Numerics.Vectors.csproj b/src/System.Numerics.Vectors/ref/System.Numerics.Vectors.csproj index ed07ba967e..05beeb02a6 100644 --- a/src/System.Numerics.Vectors/ref/System.Numerics.Vectors.csproj +++ b/src/System.Numerics.Vectors/ref/System.Numerics.Vectors.csproj @@ -3,11 +3,14 @@ <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" /> <PropertyGroup> <ProjectGuid>{650277B5-9423-4ACE-BB54-2659995B21C7}</ProjectGuid> - <IsTargetingNetFx Condition="'$(TargetGroup)'=='netfx' OR '$(TargetGroup)'=='net46'">true</IsTargetingNetFx> - <IsTargetingNetCoreApp Condition="'$(TargetGroup)'=='netcoreapp' OR '$(TargetGroup)'=='uap'">true</IsTargetingNetCoreApp> - <IsPartialFacadeAssembly Condition="'$(IsTargetingNetFx)'=='true'">true</IsPartialFacadeAssembly> - <DefineConstants Condition="'$(IsTargetingNetCoreApp)'=='true'">$(DefineConstants);netcoreapp</DefineConstants> + <IsPartialFacadeAssembly Condition="'$(TargetsNetFx)'=='true' AND '$(TargetGroup)' != 'net45'">true</IsPartialFacadeAssembly> + <DefineConstants Condition="'$(TargetsNetCoreApp)'=='true' OR '$(TargetsUap)' == 'true'">$(DefineConstants);HAS_SPAN</DefineConstants> + <!-- Must match version supported by frameworks which support 4.1.* inbox. + Can be removed when API is added and this assembly is versioned to 4.2.* --> + <AssemblyVersion Condition="'$(TargetsNetFx)' != 'true'">4.1.3.0</AssemblyVersion> </PropertyGroup> + <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'net45-Debug|AnyCPU'" /> + <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'net45-Release|AnyCPU'" /> <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'net46-Debug|AnyCPU'" /> <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'net46-Release|AnyCPU'" /> <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'netcoreapp-Debug|AnyCPU'" /> @@ -23,14 +26,14 @@ <ItemGroup> <Compile Include="System.Numerics.Vectors.cs" /> </ItemGroup> - <ItemGroup Condition="'$(IsTargetingNetFx)'=='true'"> + <ItemGroup Condition="'$(TargetsNetFx)'=='true'"> <Reference Include="mscorlib" /> <Reference Include="System.Numerics" /> </ItemGroup> <ItemGroup Condition="'$(TargetGroup)' == 'netstandard1.0'"> <Reference Include="System.Runtime" /> </ItemGroup> - <ItemGroup Condition="'$(IsTargetingNetCoreApp)'=='true'"> + <ItemGroup Condition="'$(TargetsNetCoreApp)'=='true' OR '$(TargetsUap)' == 'true'"> <ProjectReference Include="..\..\System.Runtime\ref\System.Runtime.csproj" /> </ItemGroup> <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" /> |