diff options
author | Eric St. John <ericstj@microsoft.com> | 2015-10-29 21:42:25 +0300 |
---|---|---|
committer | Eric St. John <ericstj@microsoft.com> | 2015-10-29 21:42:25 +0300 |
commit | 1c8144920c62e89f77567a16ebfa8c1324e52f07 (patch) | |
tree | 4fa5c529b5b059470a3b0a27eac961504ca82aa2 /src/System.Threading.ThreadPool/ref | |
parent | 0e051754fe95fbbb8e8336720e2fafc3559daf0b (diff) |
Raise generation of refs to match min generation of all impl.
Previously generations were strictly calculated. We had a set
of seed assemblies which defined generation boundaries based
on where they were supported. Eg: System.Runtime 4.0.0.0 was
supported inbox in Net45, 4.0.10.0 was supported inbox in
Net451, we could not OOB 4.0.0.0 to Net451 due to unification
so that defined a generation boundary.
All non-seed assemblies got the maximum generation
of all their transitive dependencies.
This worked fine, but created a confusing picture when
looking at the packages. New contracts that were only
implemented in DNXCore50 and Net46 had a reference assembly
that claimed to be dotnet5.1 even though they weren't
supported by any framework that was exclusive to 5.1-5.3.
It also meant that targeting a generation required that
someone use guardrails to ensure that they'd actually have
an implementation on any framework targeting that generation.
Without guardrails they might produce an assembly that would
not run on any framework of the generation it claimed.
This change raises the generation of all the reference assemblies
to a minimum that supports any implementation. This makes it
clear which generation of frameworks support the package,
it also lets someone target that generation without using guardrails
and guarantees that they'll at least run somewhere.
[tfs-changeset: 1543192]
Diffstat (limited to 'src/System.Threading.ThreadPool/ref')
3 files changed, 7 insertions, 7 deletions
diff --git a/src/System.Threading.ThreadPool/ref/System.Threading.ThreadPool.csproj b/src/System.Threading.ThreadPool/ref/System.Threading.ThreadPool.csproj index 4664a84dcb..99263d55a6 100644 --- a/src/System.Threading.ThreadPool/ref/System.Threading.ThreadPool.csproj +++ b/src/System.Threading.ThreadPool/ref/System.Threading.ThreadPool.csproj @@ -4,8 +4,8 @@ <PropertyGroup> <AssemblyVersion>4.0.10.0</AssemblyVersion> <OutputType>Library</OutputType> - <PackageTargetFramework>dotnet5.2</PackageTargetFramework> - <NuGetTargetMoniker>.NETPlatform,Version=v5.2</NuGetTargetMoniker> + <PackageTargetFramework>dotnet5.4</PackageTargetFramework> + <NuGetTargetMoniker>.NETPlatform,Version=v5.4</NuGetTargetMoniker> </PropertyGroup> <ItemGroup> <Compile Include="System.Threading.ThreadPool.cs" /> diff --git a/src/System.Threading.ThreadPool/ref/project.json b/src/System.Threading.ThreadPool/ref/project.json index fb92f578d9..7891fdadbd 100644 --- a/src/System.Threading.ThreadPool/ref/project.json +++ b/src/System.Threading.ThreadPool/ref/project.json @@ -4,6 +4,6 @@ "System.Runtime.InteropServices": "4.0.0" }, "frameworks": { - "dotnet5.2": {} + "dotnet5.4": {} } }
\ No newline at end of file diff --git a/src/System.Threading.ThreadPool/ref/project.lock.json b/src/System.Threading.ThreadPool/ref/project.lock.json index d48df379b2..03ebe0a075 100644 --- a/src/System.Threading.ThreadPool/ref/project.lock.json +++ b/src/System.Threading.ThreadPool/ref/project.lock.json @@ -2,7 +2,7 @@ "locked": true, "version": 2, "targets": { - ".NETPlatform,Version=v5.2": { + ".NETPlatform,Version=v5.4": { "System.IO/4.0.0": { "type": "package", "dependencies": { @@ -70,7 +70,7 @@ } } }, - ".NETPlatform,Version=v5.2/win7-x86": { + ".NETPlatform,Version=v5.4/win7-x86": { "System.IO/4.0.0": { "type": "package", "dependencies": { @@ -138,7 +138,7 @@ } } }, - ".NETPlatform,Version=v5.2/win7-x64": { + ".NETPlatform,Version=v5.4/win7-x64": { "System.IO/4.0.0": { "type": "package", "dependencies": { @@ -534,6 +534,6 @@ "System.Runtime >= 4.0.0", "System.Runtime.InteropServices >= 4.0.0" ], - ".NETPlatform,Version=v5.2": [] + ".NETPlatform,Version=v5.4": [] } }
\ No newline at end of file |