Age | Commit message (Collapse) | Author |
|
|
|
This moves all the managed pieces of Internal/Cryptography/Pal.OSX/CertificatePal.cs
which are not platform-specific into a separate file to allow them to be used in Mono.
|
|
|
|
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
|
|
Fixed by 2d4301a0
|
|
When `CancelChildren` is enabled (currently only in the `TaskCancelWait1` test)
we're hitting a race in `TaskCancelWaitTest.CreateTask()`:
1. Let's assume Task A is processing `node`
2. Task A spawns a new Task B for processing `node_1`
3. Task B starts and signals the `_countdownEvent`
4. `RealRun()` on the main thread exits the wait on `_countdownEvent`
5. `RealRun()` calls `Verify()` which loops through all the nodes and calls `VerifyCancel()`
6. We get an assertion because `CancellationToken.IsCancellationRequested` is false
7. Task A continues and sets the CancellationToken, but it is already too late by this point
To fix this race we wait on the task in `RealRun()` before proceeding to
the verification step.
This uncovered another issue:
Since `_countdownEvent` is accessed by multiple threads we have another
race between checking `_countdownEvent.IsSet` and `_countdownEvent.Signal()`.
This caused a `System.InvalidOperationException: Invalid attempt made to decrement the event's count below zero.`
Fixed it by locking access to the `_countdownEvent`.
Fixes https://github.com/dotnet/corefx/issues/20457
Fixes https://github.com/mono/mono/issues/6920
(cherry picked from commit 69cf791e365c2be6f919929c5ae521b2e070aa5d)
|
|
* Make S.S.C.X509Certificates.Tests compile against netstandard
* Fix or disable tests for netfx behavior
* Make the casing of the default X509Store Name value match netfx
* Suppress brainpool GetECDsaPublicKey tests on netfx
|
|
* Skip certificates we can't read when populating machine store.
This is a regression in 2.1.0 (https://github.com/dotnet/corefx/pull/29351).
Fixes https://github.com/dotnet/corefx/issues/29942.
* Add test
* Assert chmod returns 0
* Skip test on OSX
* Add valid content to the unreadable cert file
|
|
* Don't write a separator after the empty DN
* Make T61String behave like it does on Windows (UTF-8 with a Latin-1 fallback)
* Use the managed decoder on Linux, instead of a lot of P/Invokes back into OpenSSL.
|
|
|
|
* SignedCms with a content-type other than id-data should have attributes
* Read classic PKCS7 SignedData(EnvelopedData) documents (NetFx compat)
In NetFX if a SignedCms is created using only CmsSigners with IssuerAndSerial as
the signer identifier type, the document gets encoded using the older PKCS7
structural definition instead of the newer CMS one.
RFC 5652 has a long section (5.2.1) on how to read these documents compatibly.
Since the defaults in SignedCms / CmsSigner are the PKCS7 behavior, not
reading it means that Signed(Enveloped) documents from NetFX cannot be read.
|
|
https://github.com/mono/mono/issues/7684
This reverts commit 399c9c5a8e101bcc5c126408af95f65661105731.
|
|
|
|
* cleanup BCrypt
* fix call sites
* Revert "fix call sites"
This reverts commit 9a2cf64935bb4237d62724033765af59dfd952e0.
* fix non win call sites
* add unsafe keyword
* add unsafe keyword on pinvoke
(cherry picked from commit 756e289686080ab8e18476aacb4a419a2ee1f483)
|
|
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
(cherry picked from commit 5e1dabf5cb8fb63d3ab58c9bbfab195af9a17f50)
|
|
|
|
|
|
|
|
* Rename extension .cpp to .c
* Convert S.S.Cryptography.Native.Apple to C
* Use memset instead of consts for zero-init
|
|
* Rename extension .cpp to .c
* Convert System.Security.Cryptography.Native to C
* Address feedback comments
|
|
* disable anonymnous cipher suites to match Windows and OSX behavior
|
|
make the files compilable as part of System.dll.
|
|
|
|
array (#81)
Cherry-pick https://github.com/dotnet/coreclr/pull/18221
For https://github.com/mono/mono/pull/8626#discussion_r194984329
|
|
|
|
|
|
|
|
|
|
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
|
|
* Convert local function to an instance one to allow compilation with mcs.
* Workaround missing mcs C# 7 features.
|
|
This is a manual cherry pick of the commit due to differences in
cmake files preventing a clean merge of the normal patch. The
commit applied can be found at:
dotnet/corefx@eedd1c2784fd1c597428187985df00567bc00f86
More work will likely need to be done as more is backported and PAL
changes. In addition, the submodule will need to be updated as well.
Hopefully AIX CI should light up after that though!
|
|
|
|
Downstream https://github.com/dotnet/corefx/pull/30046
* Return same error code for invalid encoded messages in ContentInfo.GetContentType on Linux/Mac as on Windows.
* Fix compilation of CmsSignature.DSA in non-netcoreapp scenario in the same way as RSA and ECDsa.
* Handle invalid value when CmsSigner.SignerIdentifierType is being assigned in the same was as on .NET Framework.
* Throw correct exception (as documented) for incorrect index values.
|
|
baseline (#29880)
|
|
Framework behaviour. Make EnvelopedCms class partial to allow adding methods to it.
|
|
Mono had some patches in their fork of referencesource to resolve
issues on big endian. Essentially, compile-time endianness handling
is no good for big endian platforms, because they have to consume a
Monolite intended for all platforms in order to bootstrap. So then,
all big endian platforms are now consuming a bootstrap tarball made
on little endian systems, and bad things happen as a result.
This makes it so that endianness is checked at runtime by using
System.BitConverter.IsLittleEndian, not by a compiler definition.
This integrates mono/mono@1f9b218 and mono/mono@92cec46, which won't
apply cleanly to current CoreFX.
mono/mono#8679 may get fixed by this, but as the comments say,
there could be more patches missing. This just integrates the
patches known to me on UnicodeEncoding and UTF8Encoding.
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
|
|
|
|
* Convert System.Security.Cryptography.Native.Apple/pal_random.cpp to C for inclusion in Mono.
* Wrap with `BEGIN_EXTERN_C` / `END_EXTERN_C` and add `DLLEXPORT`.
|
|
|
|
|
|
|
|
|
|
|
|
mono/enable-test-FileSystemWatcher_StopCalledOnBackgroundThreadDoesNotDeadlock
Enable test fixed by https://github.com/mono/mono/pull/8719
|
|
Fix exporting of SystemNative_GetNonCryptographicallySecureRandomBytes
|
|
pal_random.c was not including pal_random.h, which declared the export. This is fine upstream, and seems to have been magically nuked between commits 9eed0fbca1ff7d95f2345259791df5e2a2945c9a and 3fb2e82f2549de0872d22e35f35de85537cb5f7f
|
|
|
|
|
|
This reverts commit 8831553c919bf74772c0b382eb2c76e1c0af873a.
|
|
|