| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
[System.Native] Exclude ReadDir pinvoke wrappers on Mono; handle EINTR
|
|
For Mono we must loop in managed when opendir/readdir/closedir return EINTR in
order to handle Thread.Abort.
This is because while a thread abort will break syscalls with EINTR, throwing the
ThreadAbortException will only happen when the pinvoke returns.
(Although opendir/readdir/clsoedir are not documented to return EINTR, they do
so on macOS Big Sur under certain conditions, so we will need to add managed looping)
Related to https://github.com/mono/mono/issues/20799
|
|
|
|
|
|
* Credscan second round
* Remove crypto changes
* Add suppression messages
* fix merge conflict
* Placeholders
|
|
* Remove crypto changes
* Update system.net.testdata
* fix UriRelativeResolutionTest.cs
* [2.1] Credscan second round (#43052)
* Credscan second round
* Remove crypto changes
* Update system.net.testdata
* fix UriRelativeResolutionTest.cs
* Add fix for HttpClientHandlerTest.cs
* more credscan
* Add more fixes
Co-authored-by: Dan Moseley <danmose@microsoft.com>
|
|
|
|
Remove all entries for issues fixed and also for all issues for which exception details are filed in.
|
|
|
|
Remove from list in cases where we have a fix pending or an exemption granted w/ inline supression
|
|
* Credentials fixes
* remove dead code
* Update PostScenarioTest.cs
Revert variable name
|
|
|
|
All of these were excluded in upstream corefx/runtime and have nothing concerning
|
|
See https://github.com/mono/mono/issues/16623#issuecomment-678248447
|
|
* Fix encoding of Digest authentication headers for servers that don't understand RFC 5987 encoding
* Quote-prefix special characters when encoding Digest headers
* Address PR feedback
|
|
|
|
(cherry picked from commit 73a3cf567a7b02ce4f984f5b791da19812fd8aa9)
Co-authored-by: Stephen Toub <stoub@microsoft.com>
|
|
* FileSystem.Unix.File.Move uses "rename" in more cases (#40611)
* FileSystem.Unix.File.Move use rename in more cases, avoid link/copy when possible, improve performance on file systems that do not support hard links, such as FAT
* Adapt Unit Tests for accounting FileSystemWatcher events fired by FileSystem.Unix.File.Move implementation that use rename in more cases, avoiding link/copy when possible
* [FileSystem] ReAdd check for same device
Co-authored-by: Sylvain <sf@ellisys.com>
Co-authored-by: Mitchell Hwang <mihw@microsoft.com>
|
|
HashTableTests.Ctor_Int_Int_GenerateNewPrime and BitConverterTests.ToString_ByteArrayTooLong_Throws
Causes issues on Windows 32bit and other platforms.
|
|
[Sockets]: Always reset internal SAEA completion when reattempting connection in MultipleConnectAsync.
|
|
connection in MultipleConnectAsync.
This should fix #18030.
|
|
Mono-specific workaround of https://github.com/mono/mono/issues/17710.
|
|
|
|
|
|
|
|
Invalidate DirectoryInfo After Create
|
|
Backport of https://github.com/dotnet/runtime/commit/db671a853e3c7a3eea5016b2dedf7b1977a17002
|
|
|
|
|
|
This reverts commit c388c710a7b3d9cfe0ea5d8fe2c1c1ddbeb46ee2.
This reverts commit f27f69ac5a5c234c7cb5c6696d0c1119d5a83b92.
|
|
Remove C# 8 nullability annotation.
|
|
|
|
Use clonefile for CopyFile, if available (#37583)
* Rework SystemNative_CopyFile to use paths instead of file descriptors
Use clonefile for CopyFile, if available
* Bail out in SystemNative_CopyFile if access fails. We don't want to proceed if the destination file is read-only.
* Handle a race condition where clonefile can result in EEXIST error
* Update comment about fcopyfile
* Update PathInternal.TrimEndingDirectorySeparator to Path.TrimEndingDirectorySeparator
* Add missing close(outFd) call
* Remove unnecessary ! operator
* Save errno around close(outFd) calls
* access already sets EACCESS errno, just keep it
* Remove fcopyfile support
* Open destination file with O_CLOEXEC
* Return correct error code for source == destination
* Rearrange error handling a bit
* Remove forgotten HAVE_FCOPYFILE
(cherry picked from commit 5f45a8d5aa116d688f92952a1de72abd8b30f1a7)
|
|
System.Net.Http.Tests.HttpContentTest.Dispose_BufferContentThenDisposeContent_BufferedStreamGetsDisposed
|
|
Fix wrong behaviour when move multiple files out of watched folder on…
|
|
* Fix inefficient interop in OSX FileSystemWatcher
Avoid unnecessary array allocations in the FileSystemWatcher callback
* Add using for FSEventStreamEventFlags
|
|
Fixes https://github.com/mono/mono/issues/17948
Pulled in upstream change https://github.com/dotnet/corefx/pull/34389
|
|
[System.Net.Http]: Add workaround for #17897.
|
|
Use `(UriKind)300` (which is the same as setting `MONO_URI_DOTNETRELATIVEORABSOLUTE=true`)
when parsing Uri headers.
|
|
(#41963)
Backport of https://github.com/dotnet/corefx/pull/41963
|
|
Backport corefx osx hidden files
|
|
We only want to change the maximum for the _default_ DOP, but the accepted maximum DOP should remain 512.
|
|
We started to see the `System.Core-xunit` step on CI to hit the timeout of 15 minutes with Linux/ARM64. That was weird, because the step used to be completed in around two minutes. With my local device (jetson board) I wasn't able to reproduce it either; it took around 100s there. We then realized it's specific to the new `taishan` CI machines, which are equipped with 64 cores. Hardcoding `mono_cpu_count` to return 16 restored the performance, however that isn't a viable fix.
Limiting `DefaultDegreeOfParallelism` to 16 fixes it, which is less extreme than limiting `mono_cpu_count ()`, still not ideal though. It seems to boil down to the fact that our non-netcore threadpool implementation doesn't handle a large number of cores well.
`repro.cs`, extracted from here https://github.com/dotnet/corefx/blob/a9b91e205a8794327a028cb4b29953127f0f194c/src/System.Linq.Parallel/tests/QueryOperators/ConcatTests.cs#L145-L154
```csharp
using System;
using System.Linq;
using System.Collections.Generic;
using System.Threading;
public class Repro {
public static void Main (string []args) {
const int ElementCount = 2048;
ParallelQuery<int> leftQuery = ParallelEnumerable.Range(0, ElementCount / 4).Union(ParallelEnumerable.Range(ElementCount / 4, ElementCount / 4));
ParallelQuery<int> rightQuery = ParallelEnumerable.Range(2 * ElementCount / 4, ElementCount / 4).Union(ParallelEnumerable.Range(3 * ElementCount / 4, ElementCount / 4));
var results = new HashSet<int>(leftQuery.Concat(rightQuery));
Console.WriteLine ("results.Count=" + results.Count + ", ElementCount=" + ElementCount);
}
}
```
Before fix:
```console
$ time ./mono/mini/mono-sgen repro.exe
results.Count=2048, ElementCount=2048
real 0m5.846s
user 0m0.344s
sys 0m1.929s
$ make -C mcs/class/System.Core run-xunit-test
[...]
=== TEST EXECUTION SUMMARY ===
net_4_x_System.Core_xunit-test Total: 48774, Errors: 0, Failed: 0, Skipped: 6, Time: 536.005s
```
With this fix:
```console
$ time ./mono/mini/mono-sgen repro.exe
results.Count=2048, ElementCount=2048
real 0m1.247s
user 0m0.206s
sys 0m0.225s
$ make -C mcs/class/System.Core run-xunit-test
[...]
=== TEST EXECUTION SUMMARY ===
net_4_x_System.Core_xunit-test Total: 48774, Errors: 0, Failed: 0, Skipped: 6, Time: 131.143s
```
|
|
|
|
|
|
|
|
Fixes https://github.com/mono/mono/issues/17304
|
