diff options
| author | Andon Andonov <andon.andonov@microsoft.com> | 2017-12-16 05:17:57 +0300 |
|---|---|---|
| committer | Jan Kotas <jkotas@microsoft.com> | 2017-12-16 05:17:57 +0300 |
| commit | df56bb3bd070ea115c4f4e157c2bee4cc6d05701 (patch) | |
| tree | 79c96e3d0b06fe54a41c0fc564fe10f6a28b8fc5 /dir.props | |
| parent | db571b1b45f06877a18899d6a6e5856e063a24db (diff) | |
ILCompiler Package Multi-Runtime Package Support (#5123)
As it stands we only produce a Windows ILCompiler package. This work implements building and publishing of OS-specific runtime packages and spins off ILCompiler as a meta-package, which can be referenced when adding to a project.
Working on this, a quirk in MSBuild behavior under .NET Core popped up - build artifacts (i.e. .targets and .props files) are imported for direct project package references, but not for runtime-specific packages, defined as dependencies in the meta-package. This doesn't seem to be the case in vanilla MSBuild.
The below is a serious hack to work around this - during runtime, we find the resolved runtime package reference and define the path to it on disk, from which all OS-specific components are loaded and run. The motivation behind the workaround was to keep the package as small as possible, particularly because of the large intersection of components between OS implementations.
All workarounds are marked as such and should be removed once Microsoft/msbuild#2807 is resolved.
There is some slowdown because of sequential resolution of targets, but not immediately noticeable and is unfortunately unavoidable - almost entirely avoided if CoreRT build targets are referenced directly (excluding MSBuild overhead).
Diffstat (limited to 'dir.props')
| -rw-r--r-- | dir.props | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -135,7 +135,7 @@ <!-- Use the shared tools host and runtime for testing --> <TestHostRootPath Condition="'$(TestHostRootPath)' == ''">$(DotnetCliPath)</TestHostRootPath> - <PackageOutputPath Condition="'$(PackageOutputPath)'==''">$(PackageOutputRoot)$(OSPlatformConfig)/</PackageOutputPath> + <PackageOutputPath Condition="'$(PackageOutputPath)'==''">$(PackageOutputRoot)$(BinDirConfiguration)/</PackageOutputPath> <SymbolPackageOutputPath Condition="'$(SymbolPackageOutputPath)'==''">$(PackageOutputPath)symbols/</SymbolPackageOutputPath> <!-- Folder where we will drop the Nuget package for the toolchain --> |