diff options
author | Michal Strehovský <MichalStrehovsky@users.noreply.github.com> | 2017-10-13 01:34:14 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-10-13 01:34:14 +0300 |
commit | 41bfc1be1d7b151a7884b325e66657ed93f87ddf (patch) | |
tree | 6e106b4d88a7628b7525303e5c77aff018744379 /src/ILCompiler.Compiler | |
parent | 3bdaa246efce30d8afe530cd1b63009268d7094a (diff) |
Log type system exceptions thrown as warnings (#4716)
This is temporary until we fix issue #72, but the scope for that issue seems rather large.
Diffstat (limited to 'src/ILCompiler.Compiler')
-rw-r--r-- | src/ILCompiler.Compiler/src/Compiler/RyuJitCompilation.cs | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/ILCompiler.Compiler/src/Compiler/RyuJitCompilation.cs b/src/ILCompiler.Compiler/src/Compiler/RyuJitCompilation.cs index 3b4385b38..1f993c832 100644 --- a/src/ILCompiler.Compiler/src/Compiler/RyuJitCompilation.cs +++ b/src/ILCompiler.Compiler/src/Compiler/RyuJitCompilation.cs @@ -79,7 +79,10 @@ namespace ILCompiler MethodIL throwingIL = TypeSystemThrowingILEmitter.EmitIL(method, ex); _corInfo.CompileMethod(methodCodeNodeNeedingCode, throwingIL); - // TODO: Log as a warning + // TODO: Log as a warning. For now, just log to the logger; but this needs to + // have an error code, be supressible, the method name/sig needs to be properly formatted, etc. + // https://github.com/dotnet/corert/issues/72 + Logger.Writer.WriteLine($"Warning: Method `{method}` will always throw because: {ex.Message}"); } } } |