diff options
| author | Alex Ghiondea <ghiondea.alexandru@microsoft.com> | 2015-12-23 23:17:35 +0300 |
|---|---|---|
| committer | Alex Ghiondea <ghiondea.alexandru@microsoft.com> | 2015-12-23 23:17:35 +0300 |
| commit | 54a7e4b76dd58797a26fcdc727f0ba296f6c367d (patch) | |
| tree | e386d328900e2fecd62d5562cb2546f35db927a2 /src/System.Private.CoreLib | |
| parent | a4e8d45a352f5952912add6ee0391a4d8f201741 (diff) | |
While porting the library I ended up updating quite a few projects to make sure they continue to work.
There were a couple of changes to the build system that are included in this change:
- The location of the tool to restore the packages is set to use dnu for now.
- When restoring packages for the internal build we need to actually pass the right parameters to the build of the depproj
There were a couple of places where we had some issues that I fixed while I was doing the port:
- The compiler gave error messages about some method out parameters not being assigned.
- There was one missing 'unsafe' modifier on an interop file
- I had to pull in a 'debug' method temporarily in the ret build. This was needed because the debug build of CoreLib currently does not build with the 'DEBUG' define.
[tfs-changeset: 1559864]
Diffstat (limited to 'src/System.Private.CoreLib')
| -rw-r--r-- | src/System.Private.CoreLib/src/Internal/Runtime/Augments/ReflectionTraceCallbacks.cs | 2 | ||||
| -rw-r--r-- | src/System.Private.CoreLib/src/System.Private.CoreLib.csproj | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/src/System.Private.CoreLib/src/Internal/Runtime/Augments/ReflectionTraceCallbacks.cs b/src/System.Private.CoreLib/src/Internal/Runtime/Augments/ReflectionTraceCallbacks.cs index fc25dac9e..0ae704acb 100644 --- a/src/System.Private.CoreLib/src/Internal/Runtime/Augments/ReflectionTraceCallbacks.cs +++ b/src/System.Private.CoreLib/src/Internal/Runtime/Augments/ReflectionTraceCallbacks.cs @@ -8,9 +8,7 @@ namespace Internal.Runtime.Augments public abstract class ReflectionTraceCallbacks { public abstract bool Enabled { get; } -#if DEBUG public abstract String GetTraceString(Type type); -#endif public abstract void Type_MakeGenericType(Type type, Type[] typeArguments); public abstract void Type_MakeArrayType(Type type); diff --git a/src/System.Private.CoreLib/src/System.Private.CoreLib.csproj b/src/System.Private.CoreLib/src/System.Private.CoreLib.csproj index 3d9588a49..9d094f773 100644 --- a/src/System.Private.CoreLib/src/System.Private.CoreLib.csproj +++ b/src/System.Private.CoreLib/src/System.Private.CoreLib.csproj @@ -59,7 +59,7 @@ <!-- CORERT-TODO: For now, drop DEBUG define comming from central location - asserts compiled into DEBUG builds use interfaces that we are not able to handle yet --> <!-- <DefineConstants>CORERT;$(DefineConstants)</DefineConstants> --> - <DefineConstants>CORERT</DefineConstants> + <DefineConstants>CORERT</DefineConstants> </PropertyGroup> <PropertyGroup Condition="'$(Platform)' == 'amd64'"> |