diff options
| author | Sascha Cunz <Sascha@BabbelBox.org> | 2012-11-23 14:41:56 +0400 |
|---|---|---|
| committer | Sascha Cunz <Sascha@BabbelBox.org> | 2012-11-23 14:41:56 +0400 |
| commit | 9094d30b932ca4b47dba81e76011efe05455a44a (patch) | |
| tree | 117c53e9ad194d00274ad98e784318bd960c4053 /tests-clar/fetchhead | |
| parent | 5cf1b4f094eb6f724b27aa01d4f0481de2e673af (diff) | |
Reset all static variables to NULL in clar's __cleanup
Without this change, any failed assertion in the second (or a later) test
inside a test suite has a chance of double deleting memory, resulting in
a heap corruption. See #1096 for details.
This leaves alone the test cases where we "just" use cl_git_sandbox_init()
and cl_git_sandbox_cleanup(). These methods already take good care to not
double delete a repository.
Fixes #1096
Diffstat (limited to 'tests-clar/fetchhead')
| -rw-r--r-- | tests-clar/fetchhead/network.c | 5 | ||||
| -rw-r--r-- | tests-clar/fetchhead/nonetwork.c | 5 |
2 files changed, 8 insertions, 2 deletions
diff --git a/tests-clar/fetchhead/network.c b/tests-clar/fetchhead/network.c index fa3b92c82..0710480cd 100644 --- a/tests-clar/fetchhead/network.c +++ b/tests-clar/fetchhead/network.c @@ -18,8 +18,11 @@ void test_fetchhead_network__initialize(void) static void cleanup_repository(void *path) { - if (g_repo) + if (g_repo) { git_repository_free(g_repo); + g_repo = NULL; + } + cl_fixture_cleanup((const char *)path); } diff --git a/tests-clar/fetchhead/nonetwork.c b/tests-clar/fetchhead/nonetwork.c index 1de5280a8..c86ae7402 100644 --- a/tests-clar/fetchhead/nonetwork.c +++ b/tests-clar/fetchhead/nonetwork.c @@ -15,8 +15,11 @@ void test_fetchhead_nonetwork__initialize(void) static void cleanup_repository(void *path) { - if (g_repo) + if (g_repo) { git_repository_free(g_repo); + g_repo = NULL; + } + cl_fixture_cleanup((const char *)path); } |