Minor iterator API cleanups

In preparation for further iterator changes, this cleans up a few
small things in the iterator API:

* removed the git_iterator_for_repo_index_range API
* made git_iterator_free not be inlined
* minor param name and test function name tweaks

1 files changed, 7 insertions, 9 deletions

diff --git a/tests-clar/status/worktree.c b/tests-clar/status/worktree.c
index 62f3f3cf3..ead1bc734 100644
--- a/tests-clar/status/worktree.c
+++ b/tests-clar/status/worktree.c
@@ -620,11 +620,9 @@ static void assert_ignore_case(
 {
 	git_config *config;
 	unsigned int status;
-	git_buf lower_case_path = GIT_BUF_INIT,
-		camel_case_path = GIT_BUF_INIT;
-
+	git_buf lower_case_path = GIT_BUF_INIT, camel_case_path = GIT_BUF_INIT;
 	git_repository *repo, *repo2;
-	
+
 	repo = cl_git_sandbox_init("empty_standard_repo");
 	cl_git_remove_placeholders(git_repository_path(repo), "dummy-marker.txt");
 
@@ -641,12 +639,12 @@ static void assert_ignore_case(
 
 	cl_git_pass(git_repository_open(&repo2, "./empty_standard_repo"));
 
-	cl_git_pass(git_buf_joinpath(&camel_case_path,
-		git_repository_workdir(repo), "Plop"));
-
 	cl_git_pass(git_status_file(&status, repo2, "plop"));
 	cl_assert_equal_i(GIT_STATUS_CURRENT, status);
 
+	cl_git_pass(git_buf_joinpath(&camel_case_path,
+		git_repository_workdir(repo), "Plop"));
+
 	cl_git_pass(p_rename(git_buf_cstr(&lower_case_path), git_buf_cstr(&camel_case_path)));
 
 	cl_git_pass(git_status_file(&status, repo2, "plop"));
@@ -660,12 +658,12 @@ static void assert_ignore_case(
 	git_buf_free(&camel_case_path);
 }
 
-void test_status_worktree__file_status_honors_ignorecase_conf_setting_set_to_true(void)
+void test_status_worktree__file_status_honors_core_ignorecase_true(void)
 {
 	assert_ignore_case(true, GIT_STATUS_CURRENT, GIT_STATUS_CURRENT);
 }
 
-void test_status_worktree__file_status_honors_ignorecase_conf_setting_set_to_false(void)
+void test_status_worktree__file_status_honors_core_ignorecase_false(void)
 {
 	assert_ignore_case(false, GIT_STATUS_WT_DELETED, GIT_STATUS_WT_NEW);
 }