Merge pull request #1038 from libgit2/Therzok-remove-forced-connection

Remove manual connection to remote

3 files changed, 5 insertions, 24 deletions

diff --git a/LibGit2Sharp/Core/NativeMethods.cs b/LibGit2Sharp/Core/NativeMethods.cs
index b71d4708..a9453529 100644
--- a/LibGit2Sharp/Core/NativeMethods.cs
+++ b/LibGit2Sharp/Core/NativeMethods.cs
@@ -1027,9 +1027,6 @@ namespace LibGit2Sharp.Core
             [MarshalAs(UnmanagedType.CustomMarshaler, MarshalCookie = UniqueId.UniqueIdentifier, MarshalTypeRef = typeof(StrictUtf8Marshaler))] string name);
 
         [DllImport(libgit2)]
-        internal static extern void git_remote_disconnect(RemoteSafeHandle remote);
-
-        [DllImport(libgit2)]
         internal static extern int git_remote_fetch(
             RemoteSafeHandle remote,
             ref GitStrArray refspecs,
diff --git a/LibGit2Sharp/Core/Proxy.cs b/LibGit2Sharp/Core/Proxy.cs
index a7b4d6ef..68888cae 100644
--- a/LibGit2Sharp/Core/Proxy.cs
+++ b/LibGit2Sharp/Core/Proxy.cs
@@ -2032,14 +2032,6 @@ namespace LibGit2Sharp.Core
             }
         }
 
-        public static void git_remote_disconnect(RemoteSafeHandle remote)
-        {
-            using (ThreadAffinity())
-            {
-                NativeMethods.git_remote_disconnect(remote);
-            }
-        }
-
         public static GitRefSpecHandle git_remote_get_refspec(RemoteSafeHandle remote, int n)
         {
             return NativeMethods.git_remote_get_refspec(remote, (UIntPtr)n);
diff --git a/LibGit2Sharp/Network.cs b/LibGit2Sharp/Network.cs
index a0216f9b..5eb1720c 100644
--- a/LibGit2Sharp/Network.cs
+++ b/LibGit2Sharp/Network.cs
@@ -404,19 +404,11 @@ namespace LibGit2Sharp
                 GitRemoteCallbacks gitCallbacks = callbacks.GenerateCallbacks();
                 Proxy.git_remote_set_callbacks(remoteHandle, ref gitCallbacks);
 
-                try
-                {
-                    Proxy.git_remote_connect(remoteHandle, GitDirection.Push);
-                    Proxy.git_remote_push(remoteHandle, pushRefSpecs,
-                        new GitPushOptions()
-                        {
-                            PackbuilderDegreeOfParallelism = pushOptions.PackbuilderDegreeOfParallelism
-                        });
-                }
-                finally
-                {
-                    Proxy.git_remote_disconnect(remoteHandle);
-                }
+                Proxy.git_remote_push(remoteHandle, pushRefSpecs,
+                    new GitPushOptions()
+                    {
+                        PackbuilderDegreeOfParallelism = pushOptions.PackbuilderDegreeOfParallelism
+                    });
             }
         }